Repository navigation
fix: make SSH command launch and cleanup portable to Windows - #1
Merged
Merged
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Windows cannot launch the generated OpenSSH ProxyCommand when Python paths are quoted with POSIX single quotes.
ssh --proxy-mode --rmalso raisesAttributeErrorbecause Windows has nosignal.SIGHUP. This PR fixes these SSH blockers and adds Windows regression coverage.This ports only the three Windows SSH commits from upstream PR googlecolab/google-colab-cli#181 onto this repository's
main(d4f855d). The unrelated upstream allocation-timeout and README changes are not included.Related upstream issue #178 and Windows support discussion #180. Thanks to @Le-Anh-Duy for the original quoting diagnosis in discussion #97.
Changes
os.devnull.Validation
Re-tested this port on native Windows 11 build 26200 with Python 3.12.14 and Windows OpenSSH:
git diff --checkpasses.uv run python integration/repro_windows_ssh/test.py: Windows OpenSSH launched the generated ProxyCommand with an identity path containing spaces, and the remote shell returnedwindows-ssh-ok. The recorded endpoint was released and the final sessions query reported no active assignments. Existing unrelated assignments are preserved.This is a scoped contribution toward native Windows support. It does not claim complete Windows feature parity or reliable cleanup after forced process termination.