Repository navigation
feat(gui): window manager, taskbar multi-window, and App Manager - #21
Open
daum110715 wants to merge 69 commits into
Open
daum110715 wants to merge 69 commits into
daum110715 wants to merge 69 commits into
Conversation
Desktop icons loaded from .desktop files displayed hardcoded English names (Terminal, Files, Chat, etc.) even in zh-CN locale. Added getAppLabel() to map known tool types to i18n keys before rendering, so system apps now show localized names while user files/folders keep their original labels. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Change default .desktop file names in filesystem.ts from English to Chinese (终端, 文件, 聊天, 仪表盘, 反馈, 文档, 设置, 编辑器) - Add label translation in loadDesktopApps() to migrate legacy English names from existing IndexedDB data - Keep getAppLabel() as render-time fallback for any missed cases Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Backend: add PUT /chat/rooms/:id for room creators to update name/description/public - Backend: add DELETE /chat/rooms/:id for room creators to delete rooms - Frontend: saveRoomSettings() now calls API before updating local state, with rollback on failure - Frontend: deleteRoom() now calls API before removing from local state, with error handling Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Format 47 frontend files with Prettier to fix CI format:check - Add CI verification rule to CONTRIBUTING.md - Add PROJECT_GUIDE.md architecture reference - Add UNIMPLEMENTED_FEATURES report (CSV + Excel) - Remove obsolete PROJECT_SUMMARY.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Replace 410 GONE stubs with full R2 CRUD for file uploads, listing, quota, download, rename, and delete - Wire FileManagerWindow.vue to upload files to cloud after local save - Auto-create notifications on feedback comments and votes - Respect user notification preferences (feedback_comment, feedback_upvote, feedback_downvote) - Skip self-notifications Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Fix notification unread count by adding total/unreadCount to backend /notifications response (notificationStore.ts expected result.total) - Fix GOI admin fields mismatch: name/acronym → title/link to match scp_goi table schema - Rewrite ChatRoomDO to persist WebSocket messages to D1 database and broadcast by room; handle chat_message, switch_room, heartbeat, rename - Add cloud sync button to FileManagerWindow.vue; download cloud files to local virtual filesystem via GET /files and GET /files/:key Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
0004_chat_messages.sql already added room_id column in a later commit. This caused fresh local databases to fail when applying 0005. Comment out the redundant ALTER TABLE and keep the index creation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- MobileFileManager: enable R2 cloud upload with dual-write (local + cloud), add syncFromCloud with binary-safe download, sanitizeFileName, and ensureDirectory for nested paths - PerformanceOptimizer: implement real score calculation in createOptimizationPlan based on issue severity and recommended strategies; fix validateImplementation to use localStorage-persisted step tracking instead of always returning false - SettingsWindow/MobileSettings: include IndexedDB storage in storageUsed stats via async calculateStorageUsed covering all 8 object stores - indexedDB: extend getStorageSize to all stores, filter availableStores before transaction to avoid NotFoundError on old DB versions, use TextEncoder for accurate byte counts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add convertToCsv() with RFC 4180 escaping and UTF-8 BOM - Add format parameter validation (json/csv only) - Fix frontend empty CSV download blocking - Add HTTP error handling in adminApi exportUsers - Pass CI + multi-agent review + 2 rounds real testing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add action validation (delete/update_status/move_category) - Add parameter validation for status and category - Gracefully handle tables without support via no-such-column catch - Frontend: dynamic batchActions based on activeTab - Frontend: prompt for status/category input in handleBatchAction - Add admin i18n translations for new batch operations - Pass CI + 2 rounds real testing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Define import schemas per table (required fields, unique fields) - Add field validation (required, illegal names) - Add unique conflict detection via pre-check query - Use D1 batch() for atomic insert of valid records - Return detailed import results (success/fail counts + error details) - Frontend: adapt handleImport to show partial success and errors - Add i18n translations for import feedback - Pass CI + 2 rounds real testing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Uncomment error detection logic for PerformanceResourceTiming - Use type assertion for responseStatus (supported in modern browsers) - Change errorCount from const to let to allow increment - Gracefully handles browsers without responseStatus support - Pass CI + real testing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add reactive watch on authStore.userId in PerformanceDashboard - Calls apiService.setUserId() when userId becomes available or changes - Fixes case where userId loads asynchronously after mount - Pass CI + real testing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add optional silent param to loadFeedbacks() to avoid loading flicker - Call loadFeedbacks(true) after successful vote and comment - Keeps existing optimistic update for immediate UI feedback - Pass CI + real testing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add shared useCloudQuota composable with caching and login check - Show cloud quota (used/max + percent) and file count in PC/Mobile settings - Add i18n translations for cloud storage quota - Include real-run test scripts for quota logic Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Backend: add /docs/goi endpoint with pagination and search - Frontend: add DocType support in useDocsReader (scp/goi/tales/hubs) - UI: add doc type tabs in PCDocsWindow and MobileDocs - Fix missing CSS variables (--docs-bg-hover, --docs-accent-soft) - Fix MobileDocs theme toggle double-switch bug - Add error feedback when non-SCP item has no URL - Include real-run test scripts for GOI API and docType mapping Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add edit_message and delete_message handlers to ChatRoomDO with ownership verification and room_id scoping - Extend useChatWebSocket with editMessage/deleteMessage methods and onMessageEdited/onMessageDeleted callbacks - Add context menu (PC) and action sheet (mobile) for edit/delete UI - Add edit mode to input bar with cancel support - Add edited indicator to message bubbles - Add i18n translations for new chat actions (en + zh-CN) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Update PROJECT_GUIDE.md with latest API routes (chat edit/delete, GOI, R2 storage) - Update README.md with 10 GUI tools and new features - Fix Prettier formatting issues in 8 files - Add chat message edited/deleted migration Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
0004_chat_messages.sql already contains the edited column, 0015 was causing D1 deployment failure due to duplicate column. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Remove .env.development and .env.production from git tracking - These files should be in .gitignore to prevent secret leaks Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ps checklist in dashboard
…e body to prevent vertical squeezing and overlapping text
…ormanceScore to ensure AAA text contrast and readability
… green branding colors in Light Mode, keeping only label text contrast corrections
…rough Multi-window support: - ToolRegistry: add seeded window-id generator to avoid Date.now() collisions when opening the same tool twice in the same tick; default new windows to non-fullscreen so multiple instances are usable side-by-side. - windowManager: extract blurWindowsExcept() helper; restore windows with a fresh zIndex and re-establish a single focused window after IndexedDB hydrate so a refresh leaves the taskbar in a consistent state. - PCTaskbar: show window-count badge per app, mark the focused window with an inset accent ring, and cycle through visible windows on repeat click (restoring minimized ones). - DesktopScreen: derive activeTools from windowManager instead of a separate ref; add a 250ms launch throttle to prevent accidental double-open from rapid clicks / double-clicks. - MobileApp: drop the desktop-only "one window per tool" guard; only enforce reuse when the tool is declared singleton. Pass existing window ids through to openTool so generated ids stay unique. - main.ts: pass the pinia instance explicitly to useTerminalStore() to avoid relying on install order. Theme fixes: - DesktopScreen / HomeScreen: scope :global(.light) icon/label overrides with :not(.claude) so the Claude theme is not overwritten by light-mode styles when both classes are present on <html>. - DesktopScreen / HomeScreen: replace hard-coded grey backgrounds on Claude icon labels with the design-system CSS variables. - CustomAccentPicker: fix the :global() selector — the panel/input rules were using :global(.light) .x (which scopes only .light), but the templates need the whole compound selector scoped, so move the inner class inside the :global(...) parens. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CI was failing on `prettier --check`. One file (HomeScreen.vue) picked up new hex colors from the previous commit; the other eight had pre-existing formatting drift on this branch that predated the multi-window work and was never caught because earlier commits didn't run the check. All changes are mechanical: lowercase hex literals, attribute wrapping, trailing commas. No behavior change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Delete 4 unused refactored composables (673 lines of dead code) - Replace axios in scraper.ts with native fetch + AbortController timeout; ApiResponseError mirrors axios error.response, TypeError/DOMException mirrors error.request — same retry and error-reporting behavior - Remove axios from package.json dependencies - Fix PCStartMenu.vue onItemClick(item: any) → proper union type, remove file-level eslint-disable comment Type-check: 0 errors. Tests: 384/384 passed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Delete MobileFeedbackWindow.vue (1180 lines, never registered/imported) - Fix TalesListPanel API_BASE: remove optional chaining and wrong fallback URL - Add uploadToCloud() and syncCloudFiles() to useFileManagerOps: uses authStore + config from composable, syncCloudFiles now handles binary/text content-type detection and directory creation properly - FileManagerWindow + MobileFileManager: replace 3 copies of duplicated cloud upload loop and 2 copies of syncFromCloud with composable calls - Remove now-unused authStore/config/cloudSyncing from both components Type-check: 0 errors. Tests: 384/384 passed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Extract shared nickname validation (nicknameValidator.ts) eliminating
4x duplicated regex/length checks across login screens and store
- Add accountType ('guest'|'registered') to auth store; guests may share
display names, only registered accounts occupy a nickname slot
- Fix logout to call clearAuthToken(), add 401 auto-retry in authFetch
- New DB migration 0015 adds account_type, is_banned, ban_reason,
banned_at to users table; worker syncs chat nickname on register
- Settings: add Account section (guest badge, inline rename, logout)
to both PC and mobile settings panels
- PC settings font-size: replace expand/collapse iOS slider with a
desktop-native control (−/slider/+ with min-max labels, live preview)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploy job now uses `if: secrets.CLOUDFLARE_API_TOKEN != ''` so it gracefully skips instead of failing when credentials are absent. Notify-failure is also scoped to actual deploy failures only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Job-level `if: secrets.* != ''` is not supported by GitHub Actions (causes workflow parse failure with 0 jobs). Instead, check the env var inside the deploy step and exit 0 gracefully when unconfigured. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Empty commit to verify the Cloudflare-secret skip logic in deploy-worker.yml without modifying worker source files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a comment to app.ts to trigger the deploy-worker workflow and confirm the Cloudflare-secret absence is handled gracefully. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolved 13 text conflicts and 1 auto-merge divergence against upstream's English-comment refactor + terminal split + test additions, while keeping the local app platform & cloud-sync work: - useTerminal.ts: kept local commandRegistry integration (upstream moved command logic into useTerminalEmulator which still uses AVAILABLE_COMMANDS). - useChatWebSocket.ts: restored upstream dev-mode WS branch. - fileService.ts / scraper.ts / commands/index.ts / commandAutocomplete.ts: merged local functional code with upstream English comments. - README.md: replaced non-existent Admin row with App Manager (local app platform UI). - PROJECT_SUMMARY.md: honored local deletion (superseded by PROJECT_GUIDE.md). - Dropped 8 upstream worker tests that exercise the removed admin feature. - Aligned ToolRegistry.test isFullscreen assertion to local default (false). typecheck green; tests green (app 1203, worker 48). Co-Authored-By: Claude <noreply@anthropic.com>
coverage/ is in .gitignore but two png files were tracked before the rule was added. Untrack them so the ignore rule takes effect. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jul 15, 2026
Owner
🔍 Code Review — Approve with minor suggestionsSummaryWindow manager with viewport-aware clamping, taskbar multi-window with badge counts and context menus, App Manager with install/uninstall catalog, ErrorBoundary, WindowCaptionControls/WindowCloseButton components. Well-structured with good test coverage. Cleanup of unused refactored composables is welcome. Warning IssuesW1. Info
Recommendation: Approve — address W2 (remove chat hardcoded min size), W4 (SSR guard), W6 (CSS variable for z-index) before merging. |
daum110715
added a commit
to daum110715/scp-os
that referenced
this pull request
Jul 15, 2026
Collaborator
Author
Addressed review suggestions
Ready to merge (was already Approve). |
Collaborator
Author
Status
No further code changes planned on this PR unless requested. |
Add App Manager (PC/Mobile), app catalog, stronger windowManager/taskbar behavior, and desktop/home integration for multi-window workflows.
daum110715
force-pushed
the
pr/gui-window-taskbar
branch
from
July 22, 2026 15:06
a8482ae to
27a1da4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop shell upgrades: shared window chrome, multi-window taskbar, pin/snap, App Manager, and safer chat send while reconnecting.
What lands
ErrorBoundary,WindowCaptionControls,WindowCloseButton; PC/SCP windows share caption controlsappCatalog+ defaultappmanager.desktopshortcutuseChatWebSocket)*Refactoredcomposable stubsIntentionally out of scope
f280de5) — coupled to local personalization & R2Base commits (shared with other open PRs)
Testing
pnpm typecheck— passNotes
DesktopScreen.vueoverlapping conceptually with fix(desktop): localize PC app names via i18n #13 i18n — rebase after either merges