Fix knife shadow - #2058
Merged
Merged
Conversation
AdamTadeusz
previously approved these changes
Aug 8, 2026
AdamTadeusz
left a comment
AdamTadeusz
left a comment
Contributor
There was a problem hiding this comment.
Do we want to put a comment somewhere that this is a hack? Setting the shadow visibility of each knife should not be done each frame
also avoid spamming effect changes with GetEffects check
Member
Author
addressed in 01ee7f1 |
AdamTadeusz
approved these changes
Aug 9, 2026
DESTROYGIRL
approved these changes
Aug 9, 2026
Contributor
|
In the future maybe we should look at clearing the model instead of controlling if its drawn or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
git cherry-pick DG's knife shadow fix from 44e757b
Toolchain
Linked Issues