Skip to content

Fix knife shadow #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rainyan merged 2 commits into from
Aug 9, 2026
Merged

Fix knife shadow #2058

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9f540
fix misinterpret
DESTROYGIRL Aug 3, 2025
01ee7f1
review feedback: add HACK comment
Rainyan Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/game/shared/neo/weapons/weapon_knife.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,24 @@ bool CWeaponKnife::CanBePickedUpByClass(int classId)
#ifdef CLIENT_DLL
bool CWeaponKnife::ShouldDraw()
{
auto owner = static_cast<CNEO_Player*>(GetOwner());
return (owner && owner->IsAlive() && owner->GetActiveWeapon() == this);
const auto owner = static_cast<CNEO_Player*>(GetOwner());
const bool draw = (owner && owner->IsAlive() && owner->GetActiveWeapon() == this);
const bool noShadow = !draw;

// NEO HACK (Rain): should be moved to some more appropriate location
if (!!(GetEffects() & EF_NOSHADOW) != noShadow)
Comment thread
DESTROYGIRL marked this conversation as resolved.
{
if (draw) // DG: Disable shadows manually because it doesn't do it on its own
{
RemoveEffects(EF_NOSHADOW);
}
else
{
AddEffects(EF_NOSHADOW);
}
}

return draw;
}
#else
bool CWeaponKnife::IsViewable()
Expand Down