Skip to content

fix: Fix regression in partial commits for FirewallCommit - #625

Merged
adambaumeister merged 1 commit into
developfrom
fix-commit-partial-regression
Jul 22, 2026
Merged

fix: Fix regression in partial commits for FirewallCommit#625
adambaumeister merged 1 commit into
developfrom
fix-commit-partial-regression

Conversation

@adambaumeister

@adambaumeister adambaumeister commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

fixes #612

tested using a simple script that implements a partial commit:

import os
from panos import firewall
from panos.firewall import FirewallCommit

if __name__ == '__main__':
    print("Committing to firewall")
    commit = FirewallCommit(
        description="test commit",
        exclude_shared_objects=True,
    )
    fw = firewall.Firewall("xxxxx", api_username="xxxx", api_password=os.getenv("PD_PASSWORD"))
    result = fw.commit(cmd=commit)
    print(result)

Partial commit works successfully:

<tenq>2026/07/21 16:46:45</tenq>
<tdeq>16:46:45</tdeq>
<id>3</id>
<user>xxx</user>
<type>Commit</type>
<status>FIN</status>
<queued>NO</queued>
<stoppable>no</stoppable>
<result>OK</result>
<tfin>2026/07/21 16:48:32</tfin>
<description>test commit</description>
<positionInQ>0</positionInQ>
<progress>100</progress>
<p2done>yes</p2done>

@horiagunica horiagunica left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adambaumeister
adambaumeister merged commit 7b71c88 into develop Jul 22, 2026
7 checks passed
@adambaumeister
adambaumeister deleted the fix-commit-partial-regression branch July 22, 2026 23:35
github-actions Bot pushed a commit that referenced this pull request Jul 22, 2026
### [1.13.1](v1.13.0...v1.13.1) (2026-07-22)

### Bug Fixes

* Fix regression in partial commits for Firewall commits specifically ([#625](#625)) ([7b71c88](7b71c88))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.13.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on 641489d381d0268817689effde55526205e550dd

2 participants