Repository navigation
refactor: move every file into its layer - #1375
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
edwinyjlim
left a comment
edwinyjlim
left a comment
There was a problem hiding this comment.
-
vitest project globs point at the old folders. vitest.config.ts:37 and :38
TUI_TESTS still reads src/ui/tui/, and CLI_TESTS still reads src/commands/ and src/lib/runners/. On this head the tui project has no files, so pnpm test:tui exits 1 with "No test files found". The cli project drops from 14 files to 2 and legacy grows from 52 to 93. vitest run stays green only because legacy is the catch-all. This file already changes in the PR, so point the globs at src/tui/** and src/cli/** here, and decide where src/tools, src/host and src/headless tests belong. -
CODEOWNERS deck paths moved. .github/CODEOWNERS:23
Lines 23 to 26 own /src/ui/tui/decks//, which no longer exists. The decks now live at /src/tui/programs//deck/, so after merge those four teams stop being requested on changes to their own decks. Update the four paths; the /src/programs/ entries above them still match.
1210053 to
d38e293
Compare
Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
d38e293 to
b8f1f7a
Compare
|
@edwinyjlim thanks, both fixed in b8f1f7a:
The stack is also rebased on main 2.79.1. |
Point the feature-flags program, deck, intro screen and test at the paths #1375 moved them to, and register the command in main.ts.
2 participants
Phase 1 of Release C (#1320), PR 2 of 2, after #1374. Green on its own.
Problem
Many files sit in folders that do not match their layer: the TUI under
src/ui/tui, CLI code undersrc/commandsandsrc/lib/runners, tools undersrc/programs. Some files also mix code from more than one layer. If the later PRs also moved code, every diff would mix moves with real changes.Changes
Moves only: file renames plus verbatim block moves, with import and export edits only. No behavior changes. 596 files changed, 2,614 insertions and 2,438 deletions: 468 renames, 26 new files that receive moved blocks, and 102 files edited for imports.
src/ui/tuimoves tosrc/tui, with each program's screens insrc/tui/programs/<id>and tool screens insrc/tui/tools/<id>.src/wizard.ts,src/commandsand the CI and headless runners move undersrc/cli. Tool code moves tosrc/tools, and MCP client code moves tosrc/shared/mcp-clients.src/lib/wizard-session.tstosrc/programs/session/,src/ui/logging-ui.tstosrc/headless/renderers/, and programsteps.tsfiles tosrc/tui/programs/<id>/flow.ts.program-scopes.ts, screen ids, run state, task status, ask policy, cleanup, and the audit and error-tracking flows.@host/*,@tools/*,@tui/*,@headless/*and@cli/*intsconfig.build.jsonandvitest.config.ts.exportadded on 8 moved symbols, one restriction path in.eslintrc.cjs, and the path filter inmcp-install.yml.tui,cliand newtoolsVitest projects readsrc/tui,src/cliandsrc/tools, and the four deck owners inCODEOWNERSpoint atsrc/tui/programs/<program>/.Test plan
pnpm typecheck: 0 errors.pnpm lint: 0 errors.vitest run: 205 test files, 3,446 tests pass.pnpm buildsucceeds.Created with PostHog Desktop