Repository navigation
chore: remove old files replaced by the new shape - #1386
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
eeede8c to
f70ef67
Compare
616023a to
50c996d
Compare
f70ef67 to
eaa3240
Compare
50c996d to
5fccf03
Compare
eaa3240 to
dfdc9c3
Compare
5fccf03 to
a777dfd
Compare
dfdc9c3 to
9c1d85d
Compare
a777dfd to
3388dae
Compare
johncwaters
left a comment
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
docs/runbooks/warlock-kill-switch.md:66: this PR deletessrc/agent/agent-runner.ts, but the kill-switch runbook still links to it as the place the flag is read at run start, and the link survives to the top of the stack. Point it atsrc/programs/wizard-flags.ts(which now callsgetAllFlagsForWizard()) or atsrc/agent/runner/.
3388dae to
989ddd1
Compare
602458a to
e88b9e5
Compare
989ddd1 to
85e2539
Compare
Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
e88b9e5 to
6b6345e
Compare
85e2539 to
1cda88f
Compare
edwinyjlim
left a comment
There was a problem hiding this comment.
Review of #1386 at 1cda88f1. Items outside this PR's diff lines:
[P3] The PR body's inventory is wrong
PR description
Partly fixed since the last push. The body says 29 files and 4,050 lines; the commit deletes 4,061.
Suggested fix: Change the deletion count to 4,061.
[P3] Two callers of deleted files are left dangling and fixed three and four PRs later
package.json:149 · scripts/tui-host.no-jest.ts:26 · scripts/tui-host.no-jest.ts:32
The body says "no file is edited", so a reader cannot tell that pnpm screens:check and the TUI host script are handled. scripts/README.md:4 also names check-screens.tsx until #1392.
Suggested fix: Fold the one-line package.json removal into this PR, and note in the body where the other two land.
[P3] @ui and @steps aliases outlive their targets
.eslintrc.cjs:68 · .eslintrc.cjs:80-81 · tsconfig.build.json:41-44 · README.md:534
Suggested fix: Remove the alias lines here or list them in the body as handled downstream.
Drafted with Claude Code from a review of the whole Release C stack, re-verified at the stack tip 2e31e438. Line numbers are at this PR's head.
Phase 2 of Release C (#1320), PR 10 of 16, after #1385. Deletions only. PRs 1 to 14 of this phase split one change into reviewable pieces and compile only as a stack: review them one by one, then land the whole phase together.
Problem
#1376 to #1385 add the new code beside the old, so the old modules are still in the tree. This PR removes them. The files the new code keeps, such as
wizard-session.ts, the runners andwizard-abort.ts, moved whole in #1375, so they are not here.Changes
Deletions only: 29 files deleted whole, 4,050 lines. No file is edited.
src/ui(wizard-ui.ts,tui/ink-ui.ts,headless-ui.ts,agent-progress.ts,index.ts) and the oldsrc/ui/tui/screen-registry.tsxandscreen-sequences.ts.src/programs/run-agent-legacy.ts,program-store.tsandauthenticate.ts,src/agent/agent-runner.ts,src/programs/posthog-doctor/index.tsandweb-analytics-doctor/steps.ts.src/steps(index.ts,run-prettier.ts,add-or-update-environment-variables.ts), the re-export filessrc/programs/detection/index.tsandsrc/programs/task-stream/index.ts,src/lib/helper-functions.ts, andmcp-role-prompts.copy.json.run-agent-legacy.test.ts,program-store.test.ts,mint-recovery.test.ts,headless-ui.test.ts,agent-progress.test.ts, andpost-auth-gates.test.tsand its snapshot. The new code's tests land in test: tests for the agent and shared layers #1387 to test: tests for the hosts, tools and cli #1390.scripts/check-screens.tsxand.prettierignore, whose only entry is a path undersrc/lib.Test plan
pnpm typecheck0 errors,pnpm lint0 errors, 3,515 tests pass in 236 files,pnpm buildok.Created with PostHog Desktop