Skip to content

chore: remove old files replaced by the new shape - #1386

Closed
gewenyu99 wants to merge 1 commit into
posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-tfrom
posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha
Closed

gewenyu99 wants to merge 1 commit into
posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-tfrom
posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha

Conversation

@gewenyu99

@gewenyu99 gewenyu99 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Phase 2 of Release C (#1320), PR 10 of 16, after #1385. Deletions only. PRs 1 to 14 of this phase split one change into reviewable pieces and compile only as a stack: review them one by one, then land the whole phase together.

Problem

#1376 to #1385 add the new code beside the old, so the old modules are still in the tree. This PR removes them. The files the new code keeps, such as wizard-session.ts, the runners and wizard-abort.ts, moved whole in #1375, so they are not here.

Changes

Deletions only: 29 files deleted whole, 4,050 lines. No file is edited.

  • The old UI layer: src/ui (wizard-ui.ts, tui/ink-ui.ts, headless-ui.ts, agent-progress.ts, index.ts) and the old src/ui/tui/screen-registry.tsx and screen-sequences.ts.
  • The old run path: src/programs/run-agent-legacy.ts, program-store.ts and authenticate.ts, src/agent/agent-runner.ts, src/programs/posthog-doctor/index.ts and web-analytics-doctor/steps.ts.
  • Old steps and barrels: src/steps (index.ts, run-prettier.ts, add-or-update-environment-variables.ts), the re-export files src/programs/detection/index.ts and src/programs/task-stream/index.ts, src/lib/helper-functions.ts, and mcp-role-prompts.copy.json.
  • Tests of the deleted code: run-agent-legacy.test.ts, program-store.test.ts, mint-recovery.test.ts, headless-ui.test.ts, agent-progress.test.ts, and post-auth-gates.test.ts and its snapshot. The new code's tests land in test: tests for the agent and shared layers #1387 to test: tests for the hosts, tools and cli #1390.
  • Also scripts/check-screens.tsx and .prettierignore, whose only entry is a path under src/lib.

Test plan

Created with PostHog Desktop

@github-actions

Copy link
Copy Markdown

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci ai-observability
  • /wizard-ci basic-integration
  • /wizard-ci feature-flags
  • /wizard-ci mcp-analytics
  • /wizard-ci replay-vision
  • /wizard-ci revenue
  • /wizard-ci self-driving
  • /wizard-ci warehouse
  • /wizard-ci warehouse-seeded

Test an individual app:

  • /wizard-ci ai-observability/anthropic
  • /wizard-ci ai-observability/google-adk
  • /wizard-ci ai-observability/groq
Show more apps
  • /wizard-ci ai-observability/manual-capture
  • /wizard-ci ai-observability/openai
  • /wizard-ci ai-observability/openai-agents
  • /wizard-ci ai-observability/opentelemetry
  • /wizard-ci ai-observability/vercel-ai
  • /wizard-ci basic-integration/android
  • /wizard-ci basic-integration/angular
  • /wizard-ci basic-integration/astro
  • /wizard-ci basic-integration/django
  • /wizard-ci basic-integration/fastapi
  • /wizard-ci basic-integration/flask
  • /wizard-ci basic-integration/flutter
  • /wizard-ci basic-integration/javascript-node
  • /wizard-ci basic-integration/javascript-web
  • /wizard-ci basic-integration/laravel
  • /wizard-ci basic-integration/next-js
  • /wizard-ci basic-integration/nuxt
  • /wizard-ci basic-integration/python
  • /wizard-ci basic-integration/rails
  • /wizard-ci basic-integration/react-native
  • /wizard-ci basic-integration/react-router
  • /wizard-ci basic-integration/sveltekit
  • /wizard-ci basic-integration/swift
  • /wizard-ci basic-integration/tanstack-router
  • /wizard-ci basic-integration/tanstack-start
  • /wizard-ci basic-integration/vue
  • /wizard-ci feature-flags/django
  • /wizard-ci feature-flags/next-js
  • /wizard-ci mcp-analytics/custom-dispatcher
  • /wizard-ci mcp-analytics/typescript-sdk
  • /wizard-ci replay-vision/javascript-node
  • /wizard-ci replay-vision/next-js
  • /wizard-ci replay-vision/react-vite
  • /wizard-ci revenue/stripe
  • /wizard-ci self-driving/astro
  • /wizard-ci self-driving/fastapi
  • /wizard-ci self-driving/nuxt
  • /wizard-ci self-driving/react-router
  • /wizard-ci self-driving/sveltekit
  • /wizard-ci warehouse/monorepo-env
  • /wizard-ci warehouse/multi-source-next
  • /wizard-ci warehouse/stripe-node
  • /wizard-ci warehouse/zero-source
  • /wizard-ci warehouse-seeded/next-stripe
  • /wizard-ci warehouse-seeded/next-stripe-declined

Test against a Context Mill branch:

  • /wizard-ci all context-mill:my-branch

Add context-mill:<branch> to any command above to pin the Context Mill branch. It defaults to main.

Results will be posted here when complete.

@gewenyu99
gewenyu99 added this pull request to stack #1394 September 29, 2026 09:41
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-t branch from eeede8c to f70ef67 Compare September 30, 2026 08:06
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from 616023a to 50c996d Compare September 30, 2026 08:06
@gewenyu99
gewenyu99 removed this pull request from stack #1394 September 30, 2026 08:07
@gewenyu99
gewenyu99 added this pull request to stack #1400 September 30, 2026 08:07
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-t branch from f70ef67 to eaa3240 Compare September 30, 2026 08:44
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from 50c996d to 5fccf03 Compare September 30, 2026 08:44
@gewenyu99
gewenyu99 marked this pull request as ready for review September 30, 2026 09:17
@gewenyu99
gewenyu99 requested review from a team as code owners September 30, 2026 09:17
@gewenyu99
gewenyu99 removed the request for review from a team September 30, 2026 09:17
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-t branch from eaa3240 to dfdc9c3 Compare September 30, 2026 14:11
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from 5fccf03 to a777dfd Compare September 30, 2026 14:11
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-t branch from dfdc9c3 to 9c1d85d Compare October 1, 2026 06:43
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from a777dfd to 3388dae Compare October 1, 2026 06:43
@gewenyu99
gewenyu99 removed this pull request from stack #1400 October 1, 2026 06:47
@gewenyu99
gewenyu99 added this pull request to stack #1403 October 1, 2026 06:47

@johncwaters johncwaters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Automated review. Not written by a human.

  • docs/runbooks/warlock-kill-switch.md:66: this PR deletes src/agent/agent-runner.ts, but the kill-switch runbook still links to it as the place the flag is read at run start, and the link survives to the top of the stack. Point it at src/programs/wizard-flags.ts (which now calls getAllFlagsForWizard()) or at src/agent/runner/.

@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from 3388dae to 989ddd1 Compare October 2, 2026 16:47
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-t branch 2 times, most recently from 602458a to e88b9e5 Compare October 2, 2026 20:50
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from 989ddd1 to 85e2539 Compare October 2, 2026 20:50
Generated-By: PostHog Desktop
Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-12-route-the-cli-e2e-harness-and-examples-t branch from e88b9e5 to 6b6345e Compare October 3, 2026 20:40
@gewenyu99
gewenyu99 force-pushed the posthog/functional-r9-13-remove-old-files-replaced-by-the-new-sha branch from 85e2539 to 1cda88f Compare October 3, 2026 20:40

@edwinyjlim edwinyjlim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of #1386 at 1cda88f1. Items outside this PR's diff lines:

[P3] The PR body's inventory is wrong
PR description

Partly fixed since the last push. The body says 29 files and 4,050 lines; the commit deletes 4,061.

Suggested fix: Change the deletion count to 4,061.

[P3] Two callers of deleted files are left dangling and fixed three and four PRs later
package.json:149 · scripts/tui-host.no-jest.ts:26 · scripts/tui-host.no-jest.ts:32

The body says "no file is edited", so a reader cannot tell that pnpm screens:check and the TUI host script are handled. scripts/README.md:4 also names check-screens.tsx until #1392.

Suggested fix: Fold the one-line package.json removal into this PR, and note in the body where the other two land.

[P3] @ui and @steps aliases outlive their targets
.eslintrc.cjs:68 · .eslintrc.cjs:80-81 · tsconfig.build.json:41-44 · README.md:534

Suggested fix: Remove the alias lines here or list them in the body as handled downstream.


Drafted with Claude Code from a review of the whole Release C stack, re-verified at the stack tip 2e31e438. Line numbers are at this PR's head.

@gewenyu99

Copy link
Copy Markdown
Collaborator Author

Folded into #1378 so the phase builds green PR by PR. This PR keeps its review; the code lands through #1378.

@gewenyu99 gewenyu99 closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants