Skip to content

feat: standardize predicate naming conventions - #643

Merged
Seddryck merged 13 commits into
next-majorfrom
feat/predicate-naming-conventions
Aug 26, 2026
Merged

feat: standardize predicate naming conventions#643
Seddryck merged 13 commits into
next-majorfrom
feat/predicate-naming-conventions

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • promote question-style predicate names to canonical metadata and runtime names
  • preserve all 71 renamed predicate names as backward-compatible aliases with an auditable rename manifest
  • update conformance metadata, generated documentation, and predicate scaffolding guidance

Validation

  • dotnet build Expressif.sln --nologo
  • dotnet test Expressif.sln --nologo --no-build --no-restore
  • dotnet format Expressif.sln analyzers --verify-no-changes --no-restore --verbosity minimal

Close #630

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 93798ef2-acd9-4025-936a-42ec35f485ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.38%. Comparing base (e83c991) to head (5174ce4).

Files with missing lines Patch % Lines
Expressif/Functions/FunctionFactory.cs 87.50% 1 Missing and 2 partials ⚠️
Expressif/Syntax/ExpressionParser.cs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           next-major     #643      +/-   ##
==============================================
+ Coverage       82.13%   82.38%   +0.25%     
==============================================
  Files             201      201              
  Lines            5938     6002      +64     
  Branches         1027     1041      +14     
==============================================
+ Hits             4877     4945      +68     
+ Misses            730      726       -4     
  Partials          331      331              
Flag Coverage Δ
expressif-cli-net10.0 36.87% <78.48%> (+3.62%) ⬆️
expressif-net10.0 81.63% <93.58%> (+0.12%) ⬆️
expressif-net8.0 81.63% <93.58%> (+0.12%) ⬆️
expressif-net9.0 81.63% <93.58%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@Seddryck Seddryck linked an issue Aug 26, 2026 that may be closed by this pull request
@Seddryck
Seddryck merged commit 2e0e6ab into next-major Aug 26, 2026
18 checks passed
@Seddryck
Seddryck deleted the feat/predicate-naming-conventions branch August 26, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize predicate naming conventions

1 participant