Skip to content

feat(array): add variadic array construction - #660

Merged
Seddryck merged 1 commit into
next-majorfrom
feat/variadic-array-function
Aug 26, 2026
Merged

feat(array): add variadic array construction#660
Seddryck merged 1 commit into
next-majorfrom
feat/variadic-array-function

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • add variadic array(...) construction with positional and spread arguments
  • support explicit and implicit spread in function calls and array literals
  • reject named array arguments and invalid spread forms during binding
  • upgrade Expressif.Syntax to 0.28.0 and refactor binder tests to construct syntax directly

Validation

  • dotnet build Expressif.sln
  • Expressif.Testing on net8.0, net9.0, and net10.0: 3,027 passed and 1 skipped per framework
  • Expressif.Cli.Tests on net10.0: 206 passed
  • dotnet format Expressif.sln analyzers --verify-no-changes --no-restore

Closes #645

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f9f7850-02f8-45f8-9d31-d358616fc131

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.92105% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.22%. Comparing base (4546914) to head (e9113b6).
⚠️ Report is 1 commits behind head on next-major.

Files with missing lines Patch % Lines
Expressif/Functions/FunctionFactory.cs 82.53% 8 Missing and 3 partials ⚠️
Expressif/Functions/BaseExpressionFactory.cs 0.00% 8 Missing ⚠️
Expressif/Bindings/ExpressifBinder.cs 89.74% 0 Missing and 4 partials ⚠️
Expressif/Serializers/FunctionSerializer.cs 0.00% 1 Missing and 1 partial ⚠️
Expressif/Values/ParameterValueConverter.cs 75.00% 1 Missing and 1 partial ⚠️
Expressif/Functions/Array/Array.cs 95.45% 1 Missing ⚠️
Expressif/Serializers/ParameterSerializer.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           next-major     #660      +/-   ##
==============================================
- Coverage       84.75%   84.22%   -0.53%     
==============================================
  Files             218      219       +1     
  Lines            6008     6143     +135     
  Branches         1060     1089      +29     
==============================================
+ Hits             5092     5174      +82     
- Misses            600      643      +43     
- Partials          316      326      +10     
Flag Coverage Δ
expressif-cli-net10.0 39.73% <42.10%> (-0.12%) ⬇️
expressif-net10.0 81.04% <78.94%> (-0.64%) ⬇️
expressif-net8.0 81.04% <78.94%> (-0.64%) ⬇️
expressif-net9.0 81.04% <78.94%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Seddryck
Seddryck merged commit 3f67f0c into next-major Aug 26, 2026
17 of 19 checks passed
@Seddryck
Seddryck deleted the feat/variadic-array-function branch August 26, 2026 09:01
@Seddryck Seddryck linked an issue Aug 26, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add variadic array(...) function for runtime array construction

1 participant