Skip to content

SONARJAVA-6476 Remove 8 rules from SonarWay and Agentic AI profiles#5676

Merged
asya-vorobeva merged 3 commits into
masterfrom
asya/remove-rules-from-sonar-way
Jun 16, 2026
Merged

SONARJAVA-6476 Remove 8 rules from SonarWay and Agentic AI profiles#5676
asya-vorobeva merged 3 commits into
masterfrom
asya/remove-rules-from-sonar-way

Conversation

@asya-vorobeva

@asya-vorobeva asya-vorobeva commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

It's a result of Analysis Trust prioritization analysis.


Summary by Gitar

  • Profile updates:
    • Removed 8 rules from the Sonar_way profile definition in Sonar_way_profile.json.
    • Updated test assertions in JavaRulesDefinitionTest.java to confirm S1104 is no longer activated by default.
    • Removed 6 rules from the Sonar_agentic_AI_profile.json definition.
  • Testing updates:
    • Removed outdated autoscan diff files associated with the removed rules in its/autoscan/src/test/resources/autoscan/diffs/.
    • Updated JavaAgenticWayProfileTest.java to adjust the expected rule count and verify exclusion of the removed rules.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Remove 8 rules from SonarWay profile SONARJAVA-6472 Remove 8 rules from SonarWay profile Jun 16, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6476

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autoscan diffs for the rules that are being removed from the Sonar way profile also need to be removed, as in this PR.

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asya-vorobeva asya-vorobeva enabled auto-merge (squash) June 16, 2026 14:37
@aurelien-coet-sonarsource

Copy link
Copy Markdown
Contributor

The metadata for the rules should also be updated on RSPEC to remove them from the Sonar way profile.

@asya-vorobeva asya-vorobeva disabled auto-merge June 16, 2026 14:41
@asya-vorobeva asya-vorobeva changed the title SONARJAVA-6472 Remove 8 rules from SonarWay profile AT-1 Remove 8 rules from SonarWay profile Jun 16, 2026
@asya-vorobeva asya-vorobeva force-pushed the asya/remove-rules-from-sonar-way branch from 906556f to 5dfebf3 Compare June 16, 2026 15:05
@asya-vorobeva asya-vorobeva deployed to sca-checking June 16, 2026 15:05 — with GitHub Actions Active
@asya-vorobeva asya-vorobeva changed the title AT-1 Remove 8 rules from SonarWay profile AT-1 Remove 8 rules from SonarWay and Agentic AI profiles Jun 16, 2026
@sonarqube-next

Copy link
Copy Markdown

@asya-vorobeva asya-vorobeva merged commit b9fd361 into master Jun 16, 2026
15 checks passed
@asya-vorobeva asya-vorobeva deleted the asya/remove-rules-from-sonar-way branch June 16, 2026 15:20
@gitar-bot

gitar-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Removes 8 rules from the Sonar_way profile and 6 rules from the Sonar_agentic_AI_profile, updating associated test assertions and autoscan diff files accordingly. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@asya-vorobeva asya-vorobeva changed the title AT-1 Remove 8 rules from SonarWay and Agentic AI profiles SONARJAVA-6476 Remove 8 rules from SonarWay and Agentic AI profiles Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants