Skip to content

SONARJAVA-6476 Remove 8 rules from SonarWay and Agentic AI profiles #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asya-vorobeva merged 3 commits into from
Jun 16, 2026
Merged

SONARJAVA-6476 Remove 8 rules from SonarWay and Agentic AI profiles #5676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0817ca2
Remove 8 rules from SonarWay profile
asya-vorobeva Jun 16, 2026
656b869
Fixed tests
asya-vorobeva Jun 16, 2026
5dfebf3
Removed also from Sonar agentic AI profile
asya-vorobeva Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S1104.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S1149.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S1444.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S1874.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S2293.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S3008.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S3740.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S8692.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions ...va-plugin/src/main/resources/org/sonar/l10n/java/rules/java/Sonar_agentic_AI_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"S1141",
"S1143",
"S1144",
"S1149",
"S1150",
"S1153",
"S1155",
Expand Down Expand Up @@ -73,7 +72,6 @@
"S1313",
"S1317",
"S1319",
"S1444",
"S1450",
"S1452",
"S1479",
Expand All @@ -100,7 +98,6 @@
"S1862",
"S1871",
"S1872",
"S1874",
"S1905",
"S1940",
"S1948",
Expand Down Expand Up @@ -181,7 +178,6 @@
"S2274",
"S2275",
"S2276",
"S2293",
"S2326",
"S2386",
"S2387",
Expand Down Expand Up @@ -222,7 +218,6 @@
"S2925",
"S2970",
"S2975",
"S3008",
"S3010",
"S3011",
"S3012",
Expand Down Expand Up @@ -259,7 +254,6 @@
"S3626",
"S3631",
"S3706",
"S3740",
"S3751",
"S3752",
"S3753",
Expand Down
8 changes: 0 additions & 8 deletions sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/Sonar_way_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"S1066",
"S1068",
"S1075",
"S1104",
"S1110",
"S1111",
"S1113",
Expand All @@ -45,7 +44,6 @@
"S1141",
"S1143",
"S1144",
"S1149",
"S1150",
"S1153",
"S1155",
Expand Down Expand Up @@ -87,7 +85,6 @@
"S1313",
"S1317",
"S1319",
"S1444",
"S1450",
"S1452",
"S1479",
Expand Down Expand Up @@ -117,7 +114,6 @@
"S1862",
"S1871",
"S1872",
"S1874",
"S1905",
"S1940",
"S1948",
Expand Down Expand Up @@ -199,7 +195,6 @@
"S2274",
"S2275",
"S2276",
"S2293",
"S2326",
"S2386",
"S2387",
Expand Down Expand Up @@ -240,7 +235,6 @@
"S2925",
"S2970",
"S2975",
"S3008",
"S3010",
"S3011",
"S3012",
Expand Down Expand Up @@ -277,7 +271,6 @@
"S3626",
"S3631",
"S3706",
"S3740",
"S3751",
"S3752",
"S3753",
Expand Down Expand Up @@ -531,7 +524,6 @@
"S8469",
"S8491",
"S8688",
"S8692",
"S8694",
"S8695",
"S8696",
Expand Down
13 changes: 10 additions & 3 deletions sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaAgenticWayProfileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void profile_is_registered_as_expected() {
BuiltInQualityProfilesDefinition.BuiltInQualityProfile actualProfile = profilesPerLanguages.get("java").get("Sonar agentic AI");
assertThat(actualProfile.isDefault()).isFalse();
assertThat(actualProfile.rules())
.hasSize(470)
.hasSize(464)
.extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey)
.doesNotContainAnyElementsOf(List.of(
"S101",
Expand All @@ -67,11 +67,17 @@ void profile_is_registered_as_expected() {
"S1104",
"S1110",
"S1124",
"S1149",
"S1195",
"S1197",
"S1444",
"S1611",
"S1659",
"S1710",
"S1874",
"S2293",
"S3008",
"S3740",
"S4719",
"S4838",
"S4925",
Expand Down Expand Up @@ -115,8 +121,9 @@ void profile_is_registered_as_expected() {
"S6833",
"S6837",
"S6912",
"S8491"
));
"S8491",
"S8692"
));
}


Expand Down
2 changes: 1 addition & 1 deletion sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaRulesDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ void test_deprecated_key() {
RulesDefinition.Repository repository = context.repository(REPOSITORY_KEY);

RulesDefinition.Rule rule = repository.rule("S1104");
assertThat(rule.activatedByDefault()).isTrue();
assertThat(rule.activatedByDefault()).isFalse();
assertThat(rule.deprecatedRuleKeys()).containsExactly(RuleKey.of("squid", "ClassVariableVisibilityCheck"));

// FIXME SONAR-17167: S4830 should have references to java:S4244 and squid:S4244
Expand Down
Loading