refactor: merge arc stack into development - #134
Conversation
Consolidate server plugin examples, flatten the schema submodule, and move shared resource and checksum helpers into the client module. Remove stale documentation and test drivers, update coverage and build targets, and verify installer replacement and resumable multi-module release preparation. BREAKING CHANGE: github.com/calypr/syfon/common is removed. Import resource helpers from github.com/calypr/syfon/client/access and NormalizeOid and NormalizeChecksum from github.com/calypr/syfon/client/hash. Existing client exports and the server plugin contract remain unchanged.
✅ Deploy Preview for drs-server ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cba6e4efb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| fetch-depth: 0 | ||
| ref: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_sha || github.sha }} | ||
| ref: ${{ github.event_name == 'workflow_run' && 'development' || github.ref }} |
There was a problem hiding this comment.
If development advances after this workflow_run is queued—for example, when an earlier release's sync-module-versions job pushes its [skip ci] commit—this checkout resolves the newer branch tip rather than workflow_run.head_sha, so the verification at line 65 fails and the triggering commit is never released. Since the sync commit skips CI, it does not produce a replacement release run, leaving those changes unpublished until another ordinary development push occurs; check out the immutable triggering SHA here instead.
Useful? React with 👍 / 👎.
1 participant
This proposes the existing
refactor/arc-16stack tip directly againstdevelopment, carrying the remaining stack from PR #117 through PR #129.This PR preserves the original stack branch and commit history. Dependabot PRs #94, #95, and #112 remain separate.
The stack component PRs passed their GitHub CI and independent exact-head review. PR #129 also passed its full CI after the SDK README, release versioning, dependency, and workflow security fixes.