Add Criterion benchmarks - #9
Open
valadaptive wants to merge 2 commits into
Open
valadaptive wants to merge 2 commits into
valadaptive wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For optimization, it's nice to have a benchmark suite. This PR adds a couple basic benchmarks for the speech and audio modes.
I also updated the
benchprofile so it emits and preserves full debug info. This is necessary for performance profiling (I like to use samply).While working on this, I noticed that while
audio_utils::load_as_mono(which returns anAudioSignal) is public, theAudioSignaltype itself is not, which makes the API quite awkward to use. Let me know if you want a PR for that as well.