Re-enable the funnel and flow live tests - #35
Merged
Conversation
Both were `it.skip`ed on the grounds that /v0/funnel and /v0/flow only accepted camelCase dateFrom/dateTo, so a snake_case call would 400. That is no longer true — the pipes were unified API-side. Verified live against api.formo.so: funnel returns 23,127 users and flow returns 156 transitions for snake_case date_from/date_to. Leaving them skipped meant the CLI's snake_case behaviour was only covered by a unit test asserting what it sends, with nothing checking the API still accepts it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Both tests were
it.skiped with a comment saying/v0/funneland/v0/flowonly accepted camelCasedateFrom/dateTo, so the CLI's snake_case call would return a 400. That is no longer true — the pipes were unified API-side, andopenapi.jsonhas documenteddate_from/date_tofor both for a while now.Verified live against
api.formo.sowith a fresh read-scoped key:analytics funnel --date-from 2026-06-01 --date-to 2026-07-31→ 23,127 users at step 1analytics flow --date-from 2026-06-01 --date-to 2026-07-31→ 156 transitionsImpact
While skipped, the CLI's snake_case behaviour was covered only by a unit test asserting what it sends — nothing verified the API still accepts it. Re-enabled, these two guard against a regression to camelCase-only.
Suite goes from 189 passing / 3 pending to 191 passing / 1 pending. The one remaining skip is the wallet-import write test, which is deliberately gated behind an opt-in flag.
Note on CI
These live tests only run when
TEST_TOKENis valid. The repo secret is currently rejected with a 401, so CI has been skipping the whole live suite — it needs refreshing for this PR to actually exercise anything on CI.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.