Skip to content

Re-enable the funnel and flow live tests #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosriady merged 1 commit into from
Aug 3, 2026
Merged

Re-enable the funnel and flow live tests #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions test/commands/analytics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,10 @@ describe('commands/analytics', function () {
expect(result).to.exist;
});

// SKIPPED until the API-side fix unifying /v0/funnel and /v0/flow to
// snake_case date_from/date_to is deployed. The CLI now sends snake_case
// (see buildAnalyticsParams); production still only accepts camelCase
// dateFrom/dateTo for these two pipes, so a live call returns HTTP 400.
// Re-enable (.skip -> it) once the API change ships. The deterministic
// snake_case unit test above keeps the CLI behavior locked meanwhile.
it.skip('returns data from the funnel pipe (snake_case dates + JSON steps)', async function () {
// /v0/funnel and /v0/flow accept snake_case date_from/date_to — the pipes
// that once required camelCase were unified API-side, verified live. These
// two guard that: a regression to camelCase-only would 400 here.
it('returns data from the funnel pipe (snake_case dates + JSON steps)', async function () {
await requiresLiveApi(this);
const result = (await runAnalytics('funnel', {
dateFrom: '2026-03-01',
Expand All @@ -220,7 +217,7 @@ describe('commands/analytics', function () {
expect(result).to.have.property('data');
});

it.skip('returns data from the flow pipe (snake_case dates + JSON start_step)', async function () {
it('returns data from the flow pipe (snake_case dates + JSON start_step)', async function () {
await requiresLiveApi(this);
const result = (await runAnalytics('flow', {
dateFrom: '2026-03-01',
Expand Down