Skip to content

Fixup pointer tests after buffer_view landed#4684

Merged
dneto0 merged 1 commit into
gpuweb:mainfrom
alan-baker:fix-pointer-tests
Jul 17, 2026
Merged

Fixup pointer tests after buffer_view landed#4684
dneto0 merged 1 commit into
gpuweb:mainfrom
alan-baker:fix-pointer-tests

Conversation

@alan-baker

Copy link
Copy Markdown
Contributor
  • Pointers to runtime arrays can be declared in workgroup and uniform storage classes with the buffer_view language feature

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

* Pointers to runtime arrays can be declared in workgroup and uniform
  storage classes with the buffer_view language feature
@alan-baker
alan-baker requested review from dj2 and dneto0 July 17, 2026 17:26
@github-actions

Copy link
Copy Markdown

Results for build job (at 418bee4):

-webgpu:shader,validation,types,pointer:type:* - 29 cases, 29 subcases (~1/case)
+webgpu:shader,validation,types,pointer:type:* - 31 cases, 31 subcases (~1/case)
-webgpu:shader,validation,types,pointer:ptr_not_instantiable:* - 15 cases, 15 subcases (~1/case)
+webgpu:shader,validation,types,pointer:ptr_not_instantiable:* - 13 cases, 13 subcases (~1/case)

@dneto0
dneto0 merged commit f418634 into gpuweb:main Jul 17, 2026
1 check passed
@alan-baker
alan-baker deleted the fix-pointer-tests branch July 17, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants