Skip to content

Fixup pointer tests after buffer_view landed #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dneto0 merged 1 commit into from
Jul 17, 2026
+20 −3
Merged

Fixup pointer tests after buffer_view landed #4684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/webgpu/shader/validation/types/pointer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ interface TypeCase {
storable: boolean;
f16?: boolean;
aspace?: string;
buffer_view?: boolean;
}

const kTypeCases: Record<string, TypeCase> = {
Expand Down Expand Up @@ -150,13 +151,31 @@ const kTypeCases: Record<string, TypeCase> = {

// Reference
reference: { type: `ref<function, u32>`, storable: false, aspace: 'function' },

// Runtime arrays (allowed by buffer_view).
uniform_runtime_array: {
type: 'array<u32>',
storable: true,
aspace: 'uniform',
buffer_view: true,
},
workgroup_runtime_array: {
type: 'array<u32>',
storable: true,
aspace: 'workgroup',
buffer_view: true,
},
};

g.test('type')
.desc('Tests that pointee type must be storable')
.params(u => u.combine('case', keysOf(kTypeCases)))
.fn(t => {
const testcase = kTypeCases[t.params.case];
let expect = testcase.storable;
if (testcase.buffer_view === true) {
expect &&= t.hasLanguageFeature('buffer_view');
}
const aspace = testcase.aspace ?? 'storage';
const access = testcase.type.includes('atomic') ? ', read_write' : '';
const code = `${testcase.f16 ? 'enable f16;' : ''}
Expand All @@ -165,7 +184,7 @@ g.test('type')
struct T { s : array<S> }
alias u32_alias = u32;
alias Type = ptr<${aspace}, ${testcase.type}${access}>;`;
t.expectCompileResult(testcase.storable, code);
t.expectCompileResult(expect, code);
});

// Address spaces that can hold an i32 variable.
Expand Down Expand Up @@ -269,8 +288,6 @@ const kStoreTypeNotInstantiable: Record<string, string> = {
privateAtomic: 'alias p = ptr<private,atomic<u32>>;',
functionAtomic: 'alias p = ptr<function,atomic<u32>>;',
uniformAtomic: 'alias p = ptr<uniform,atomic<u32>>;',
workgroupRTArray: 'alias p = ptr<workgroup,array<i32>>;',
uniformRTArray: 'alias p = ptr<uniform,array<i32>>;',
privateRTArray: 'alias p = ptr<private,array<i32>>;',
functionRTArray: 'alias p = ptr<function,array<i32>>;',
RTArrayNotLast: 'struct S { a: array<i32>, b: i32 } alias p = ptr<storage,S>;',
Expand Down
Loading