Adding AWS multiple tags support - #112
Open
abaez wants to merge 6 commits into
Open
Conversation
|
|
|
+1 for this. Are there any blockers for this to get merged? |
|
+1 IMHO should had been done like awscli does it from the very beginning, much easier to parse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going with what was brought up in issue #36, the following change introduces the ability to use multiple tags for AWS.
The work was done by replacing
tag_keyandtag_valuewithtag_filters. Doing so also meant adding small tests to make sure the type definitions were correct. Due to the structure, this change may be applicable for all the providers which usetag_keyandtag_valuedeclarations.If it's possible, I would like to get some feedback before squashing and rebasing the PR.