Skip to content

fix(e2e): send phase 8 follow-up as interrupt - #113

Merged
chocobar merged 1 commit into
mainfrom
fix/e2e-phase8-interrupt
Oct 12, 2026
Merged

chocobar merged 1 commit into
mainfrom
fix/e2e-phase8-interrupt

Conversation

@chocobar

Copy link
Copy Markdown

Bug

Helix Drone build 5019 timed out in Zed E2E protocol lifecycle Phase 8. The phase claims to send an interrupt but called SendChatMessage, whose test helper sends interrupt=false. Under one timing, the normal follow-up became a separate Zed-originated turn with a generated request ID, so the strict Phase 8 completion check never observed its expected interrupt request ID.

Fix

Send the Phase 8 follow-up through SendChatMessageWithInterrupt(..., true) with the phase's request ID. Keep the strict completion assertion. Other phases continue to use their existing send path.

Tests

  • E2E test-server go test ./... with a temporary module file pointing at the local Helix checkout
  • git diff --check

Full Zed E2E validation requires CI. This PR must be merged before the Helix ZED_COMMIT pin is published.

@chocobar
chocobar merged commit 37ffbe7 into main Oct 12, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant