Repository navigation
fix(e2e): send phase 8 follow-up as interrupt - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Helix Drone build 5019 timed out in Zed E2E protocol lifecycle Phase 8. The phase claims to send an interrupt but called
SendChatMessage, whose test helper sendsinterrupt=false. Under one timing, the normal follow-up became a separate Zed-originated turn with a generated request ID, so the strict Phase 8 completion check never observed its expected interrupt request ID.Fix
Send the Phase 8 follow-up through
SendChatMessageWithInterrupt(..., true)with the phase's request ID. Keep the strict completion assertion. Other phases continue to use their existing send path.Tests
go test ./...with a temporary module file pointing at the local Helix checkoutgit diff --checkFull Zed E2E validation requires CI. This PR must be merged before the Helix
ZED_COMMITpin is published.