Skip to content

fix(e2e): send phase 8 follow-up as interrupt #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chocobar merged 1 commit into from
Oct 12, 2026
Merged

fix(e2e): send phase 8 follow-up as interrupt #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions crates/external_websocket_sync/e2e-test/helix-ws-test-server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,18 +441,25 @@ func (d *testDriver) syncEventCallback(sessionID string, syncMsg *types.SyncMess
}
}

// Phase 8: send an interrupt as soon as the first assistant token arrives for
// the phase 8 thread. This guarantees ACP has started generating (running_turn
// is set), so the interrupt will properly cancel the active turn via run_turn().
// Phase 8: send an interrupt on the first assistant event for the phase 8
// thread, while the initial turn is still active.
if d.phase == 8 && !d.round.phase8InterruptSent {
role, _ := syncMsg.Data["role"].(string)
threadID, _ := syncMsg.Data["acp_thread_id"].(string)
if role == "assistant" && threadID == d.round.phase8ThreadID {
d.round.phase8InterruptSent = true
agentName := d.round.agentName
requestID := d.round.reqID("phase8-interrupt")
d.mu.Unlock()
log.Printf("[%s] Phase 8: First assistant token arrived, sending interrupt to %s", agentName, truncate(threadID, 16))
d.sendChatMessage("Actually just say 'hello'.", d.round.reqID("phase8-interrupt"), agentName, threadID)
log.Printf("[%s] Phase 8: First assistant event arrived, sending interrupt to %s", agentName, truncate(threadID, 16))
routedSessionID, ok := d.srv.ContextMappings()[threadID]
if !ok {
log.Printf("[test-server] WARNING: Phase 8 interrupt %s has no session mapping for thread %s", requestID, threadID)
return
}
if err := d.srv.SendChatMessageWithInterrupt(routedSessionID, "Actually just say 'hello'.", requestID, true); err != nil {
log.Printf("[test-server] WARNING: Phase 8 interrupt %s failed for session %s: %v", requestID, routedSessionID, err)
}
return
}
}
Expand Down