fix: remove incorrect max-validity constraint on lifetime input - #47
Merged
Merged
Conversation
closes #26 - components/ipns-inspector.tsx: remove MAX_VALIDITY (was 1 year in seconds) used as max on a milliseconds input, causing browser validation error even for the "1 day" preset - lib/ipns-machine.tsx: fix misleading comment ("in seconds" -> "in milliseconds")
lidel
commented
Feb 26, 2026
| DialogTrigger, | ||
| } from './ui/dialog' | ||
|
|
||
| const MAX_VALIDITY = 365 * 24 * 60 * 60 // 1 year in seconds |
Contributor
Author
There was a problem hiding this comment.
ℹ️ afaik there is no 1y limit in specs, we should allow people to create records that are valid for 50 years if they wish, for testing purposes (we have such records in gateway-conformance)
storacha proof expired on 2026-01-24, comment out storacha creds and add ipfs cluster credentials instead
🚀 Build Preview on IPFS ready
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes: