Skip to content

fix: remove incorrect max-validity constraint on lifetime input #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidel merged 2 commits into from
Mar 2, 2026
Merged

fix: remove incorrect max-validity constraint on lifetime input #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c16407c
fix: remove incorrect max-validity constraint on lifetime input
lidel Feb 26, 2026
eb392a3
ci: switch deploy from storacha to ipfs cluster
lidel Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,11 @@ jobs:
id: deploy
with:
path-to-deploy: ${{ env.BUILD_PATH }}
storacha-key: ${{ secrets.STORACHA_KEY }}
storacha-proof: ${{ secrets.STORACHA_PROOF }}
cluster-url: ${{ secrets.CLUSTER_URL }}
cluster-user: ${{ secrets.CLUSTER_USER }}
cluster-password: ${{ secrets.CLUSTER_PASSWORD }}
# storacha-key: ${{ secrets.STORACHA_KEY }} # disabled: proof expired 2026-01-24
# storacha-proof: ${{ secrets.STORACHA_PROOF }} # disabled: proof expired 2026-01-24
pinata-jwt-token: ${{ secrets.PINATA_JWT_TOKEN }}
github-token: ${{ github.token }}

Expand Down
2 changes: 0 additions & 2 deletions components/ipns-inspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
DialogTrigger,
} from './ui/dialog'

const MAX_VALIDITY = 365 * 24 * 60 * 60 // 1 year in seconds

@lidel lidel Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ afaik there is no 1y limit in specs, we should allow people to create records that are valid for 50 years if they wish, for testing purposes (we have such records in gateway-conformance)

const DAY_MS = 24 * 60 * 60 * 1000

export const NAME_VALIDATION_ERROR = 'IPNS names must be base36 encoded CIDs or base58 encoded libp2p PeerIDs'
Expand Down Expand Up @@ -289,7 +288,6 @@ export default function IPNSInspector() {
value={state.context.formData.lifetime}
onChange={(e) => send({ type: 'UPDATE_FORM', field: 'lifetime', value: e.target.value })}
min="1"
max={MAX_VALIDITY}
/>

<Button
Expand Down
2 changes: 1 addition & 1 deletion lib/ipns-machine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { peerIdFromString } from '@libp2p/peer-id'
import type { PeerId, Ed25519PrivateKey } from '@libp2p/interface'
import 'core-js/modules/esnext.uint8-array.to-base64'
import { base36 } from 'multiformats/bases/base36'
export const DEFAULT_LIFETIME_MS = 24 * 60 * 60 * 1000 // 24 hours in seconds
export const DEFAULT_LIFETIME_MS = 24 * 60 * 60 * 1000 // 24 hours in milliseconds

export type Mode = 'inspect' | 'create'

Expand Down