Fix directory workspace opens and discover loose kwt sessions - #257
Merged
Merged
Conversation
Directory workspaces could remain at the loading screen because the pinned helper rejects a lone --expected-session flag. Omit the worktree-only guards for directory opens, while keeping the full identity checks for Git worktrees. Discover loose sessions on both the default and kwt tmux servers. Preserve the socket through selection and lifecycle actions so matching names remain distinct and registered workspaces suppress only their own session rows. Exercise directory creation and reopening with the pinned helper. Confine its tmux subprocesses to the test server even when kwt clears TMUX_TMPDIR. Fixes #252. Fixes #256. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
This comment has been minimized.
This comment has been minimized.
The Sequoia compatibility build fails because Xcode 26.0.1 cannot type-check one expression that constructs both discovery queries. Give the socket list and closure explicit types and join the queries separately, preserving the commands and socket behavior. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 12:14 — with 
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 12:14 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 12:14 — with
GitHub Actions
Active
GitHub Actions
Active
This comment has been minimized.
This comment has been minimized.
A custom TMUX_TMPDIR sent Ghosthub to a different kwt server than the pinned helper. Clear that override for canonical kwt operations so discovery, attachment, and session actions reach the same server. Keep the account's socket directory for default and other named servers, including protected endpoints that can use a legacy directory. The regression uses separate canonical and custom test directories. Its tmux shim confines commands that clear the override while preserving explicit roots, so the test can distinguish the servers without reaching user sessions. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 13:46 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 13:46 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 13:47 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 13:48 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 13:48 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 13:48 — with
GitHub Actions
Active
GitHub Actions
Active
This comment has been minimized.
This comment has been minimized.
An unreadable kwt server must not hide healthy default-server sessions or block their reconnects. Publish the available rows with a host warning and keep cached kwt rows until a complete refresh can confirm their state. Preserve that distinction when another window joins the shared inventory. Directory registration can change while kwt opens a workspace. Confirm the launched client's identity against the selected endpoint on default sockets as well as named sockets before showing the terminal or allowing reconnect. A still-present session with the old name does not prove the client chose it. Addresses the approved Medium findings in PR #257 review comments: #257 (comment) #257 (comment) Generated with Codex Co-authored-by: Codex <noreply@openai.com>
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 17:03 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 17:03 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 17:03 — with
GitHub Actions
Active
GitHub Actions
Active
This comment has been minimized.
This comment has been minimized.
The socket-directory fix and partial discovery behavior belong to the Swift app. Placing them inside the Windows/WSL contract implied the Rust port had the same behavior. Give the Swift contract its own paragraph and identify the app covered by the sessions Guide. Addresses the approved documentation-scope finding from local RoboRev job 4285 on 936fa70. Rust WSL behavior is unchanged. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 18:25 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 18:25 — with
GitHub Actions
Active
GitHub Actions
Active
wesm
deployed
to
sandbox-image-promotion-status
September 17, 2026 18:25 — with
GitHub Actions
Active
GitHub Actions
Active
roborev: Combined Review (
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TMUX_TMPDIR; retain the account's directory for default and other named servers.