Fix degCovariates() stroke colours to match documentation - #71
Open
CodingKaiser wants to merge 1 commit into
Open
Fix degCovariates() stroke colours to match documentation#71CodingKaiser wants to merge 1 commit into
CodingKaiser wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues with the visualization and documentation consistency in the
degCovariates()function, and corrects some function calls in the package. The main focus is to ensure that the plot layers and colors match the intended interpretation described in the documentation.Visualization and Documentation Consistency:
degCovariates(), so that grey points (correlation p-value < 0.05) are drawn first, and black points (covariates significant in the linear model) are drawn on top, matching the documentation. The black layer now correctly uses the linear-model p-value instead of the correlation FDR. [1] [2]