Skip to content

Fix degCovariates() stroke colours to match documentation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodingKaiser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix degCovariates() stroke colours to match documentation #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ DEGreport News

CHANGES IN DEGreport 1.45.1

* Fixed degCovariates() stroke colours so they match the documentation:
the grey (correlation p-value < 0.05) layer was drawn on top of the
black layer, hiding it, and the black layer was keyed to the correlation
FDR rather than the linear-model p-value. Now grey marks the first-pass
correlation hits and black (drawn on top) marks covariates significant
in the linear model.
* Fixed labs() function calls in multiple R files:
- methods.R (2 occurrences in degMean and degVar functions)
- clustering.R (2 occurrences)
Expand Down
4 changes: 2 additions & 2 deletions R/covariate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,10 +451,10 @@ degCovariates <- function(counts, metadata,
fill = ~r,
shape = ~type_variable)) +
geom_point() +
geom_point(data = filter(ma_plot, !is.na(fdr)),
stroke = 1, color="black") +
geom_point(data = filter(ma_plot, pvalue<0.05),
stroke = 1, color="grey60") +
geom_point(data = filter(ma_plot, !is.na(p.value)),
stroke = 1, color="black") +
theme_minimal() +
scale_shape_manual(values = c(22, 21)) +
scale_size_continuous(name = "importance",
Expand Down