Improve /support and /foundation/members designs#3534
Conversation
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
|
Cloudflare doesnt like to comment I guess: https://mtrnord-members-support-rede.matrix-website.pages.dev/ |
|
maybe /support should also have the downward arrow ui hint from /try-matrix? 
iirc the membership contracts guarantees platinum to have a bigger logo on the page than gold than silver
|
Hm good idea
Hm ok I forgot about that. It just looked weird if i kept the original sizes in this setup 🤔 since it became extremely noticeable (though plat and gold were the same size in the old design it seems? and only the rest was smaller than those 2) Not yet sure what to do about that. Hm. |
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Deploying matrix-website with
|
| Latest commit: |
70c5cf2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4698e7fa.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-members-support-rede.matrix-website.pages.dev |
then that was probably correct |
Moves .breadcrumb out of _support.scss into _breadcrumb.scss, matching the structure used in other PRs of mine. Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
| </div> | ||
| <div id="most-popular" class="tier-card"> | ||
| <div id="most-popular" class="tier-card tier-card--group-start tier-card--silver"> | ||
| <p class="tier-card-eyebrow">For organisations</p> |
There was a problem hiding this comment.
have you tried how this would look following this approach?
There was a problem hiding this comment.
but it would need to stay how it currently works or an entirely new solution for the mobile view
|
https://github.com/matrix-org/website-wg/issues/17 is also a thing |
| // _breadcrumb.scss partial - see there for the .page-header (dark) context | ||
| // both pages use. | ||
|
|
||
| .membership { |
There was a problem hiding this comment.
the membership part of the style should perhaps split into a new members.scss
There was a problem hiding this comment.
maybe the .step-flow $.colored should use #eee of the current support page rather than #fafafa? the latter is indistinguishable from white to me
| <div class="step-background" id="working-group"> | ||
| <div class="step no-image"> | ||
| <div class="instructions"> | ||
| <h2>Join a working group</h2> |
There was a problem hiding this comment.
| <h2>Join a working group</h2> | |
| <h2>Join a Working Group</h2> |
style guide defines this spelling in the meantime. pls also update the text!!
| --color-tier-platinum: #b8c4cc; | ||
| --color-tier-platinum-badge: #5b6b74; | ||
| --color-tier-gold: #c9a227; | ||
| --color-tier-gold-badge: #8a6d1c; | ||
| --color-tier-silver: #7c7f83; | ||
| --color-tier-silver-badge: #5c5f63; |
There was a problem hiding this comment.
maybe check if you can reuse the precise colors or at least inspiration from the member badges on /branding and or check in with jordan
|
requesting review from andy to confirm whatever we do here matches the membership contract requirements |
2 participants
Description
More of an experiment trying to align it with all the other changes I proposed. Not sure if it is actually the right direction or not. For sure needs further feedback. I would love a proper masonry layout for example but I seem to not have css support for that :/
Related issues
I guess #2198
Role
Website & Content WG
Timeline
Lets take our time on this one and discuss before thinking about timelines :)
Signoff
Please sign off your individual commits.