-
-
Notifications
You must be signed in to change notification settings - Fork 452
Improve /support and /foundation/members designs #3534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MTRNord
wants to merge
4
commits into
main
Choose a base branch
from
MTRNord/members-support-redesign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
92339de
improve /support and /foundation/members designs
MTRNord 8598b5e
add a css make plat and gold sponsors larger than the rest
MTRNord 1316047
add a js based masonry layout to the members page
MTRNord 70c5cf2
extract the breadcrumb component into its own partial
MTRNord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Breadcrumb navigation | ||
| // Used via macros/breadcrumb.html. Two contexts: | ||
| // 1. Inside .page-header (dark background) - text is white/muted-white | ||
| // 2. Inside .detail-page (light background) - text is muted grey | ||
|
|
||
| .breadcrumb { | ||
| ol { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| align-items: center; | ||
| list-style: none; | ||
| margin: 0; | ||
| padding: 0; | ||
| gap: 0.25rem; | ||
| font-size: 0.85rem; | ||
| } | ||
|
|
||
| li { | ||
| display: flex; | ||
| align-items: center; | ||
|
|
||
| // Chevron separator before every item except the first | ||
| & + li::before { | ||
| content: "/"; | ||
| margin-right: 0.25rem; | ||
| opacity: 0.45; | ||
| } | ||
| } | ||
|
|
||
| a, | ||
| span { | ||
| text-decoration: none; | ||
| line-height: 1; | ||
| } | ||
|
|
||
| // Dark context (inside .page-header) | ||
| .page-header & { | ||
| margin-bottom: 0.75rem; | ||
|
|
||
| a { | ||
| color: rgb(255 255 255 / 70%); | ||
|
|
||
| &:hover { | ||
| color: #fff; | ||
| } | ||
| } | ||
|
|
||
| // 45% white only clears ~4.4:1 against the black hero background, | ||
| // just under AA's 4.5:1 for text; 60% keeps it safely above. | ||
| span { | ||
| color: rgb(255 255 255 / 60%); | ||
| } | ||
|
|
||
| li + li::before { | ||
| color: rgb(255 255 255 / 45%); | ||
| } | ||
| } | ||
|
|
||
| // Light context (inside .detail-page) | ||
| .detail-page & { | ||
| margin-bottom: 1.25rem; | ||
|
|
||
| a { | ||
| color: var(--color-text-muted); | ||
|
|
||
| &:hover { | ||
| color: var(--color-text); | ||
| } | ||
| } | ||
|
|
||
| // The current-page label is text, not decoration, so it still needs | ||
| // to clear WCAG AA (4.5:1); #aaa on white only manages ~2.3:1. | ||
| span { | ||
| color: var(--color-text-light); | ||
| } | ||
|
|
||
| li + li::before { | ||
| color: #ccc; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe check if you can reuse the precise colors or at least inspiration from the member badges on /branding and or check in with jordan