fix(verify): correct doc drift in TR-08 verification skill - #71
Draft
mite404 wants to merge 1 commit into
Draft
Conversation
- Fix track volume range: -45 to +5 dB (not -60 to +6) - Clarify BPM bounds: data layer enforces 40-300, UI doesn't clamp - Source: TrackControls.tsx lines 79-81, App.tsx handleIncrementBpm/handleDecrementBpm Co-authored-by: Ethan Anderson <mite404@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes documentation drift found during the scheduled maintenance pass for
.agents/skills/verify-tr-08/.Drift Corrections
Track volume range (
track-controls.md)src/components/TrackControls.tsxlines 79-81BPM bounds enforcement (
playback-controls.md)src/App.tsxhandleIncrementBpm/handleDecrementBpm(lines 601-617)Verification Method
Source-code review of:
src/components/TrackControls.tsx(volume knob min/max)src/App.tsx(BPM increment/decrement handlers)src/types/beat.ts(Zod schema validation)Live Testing
Live testing was blocked by network connectivity issues in the Cloud Agent VM (npm/curl SSL failures preventing dependency installation). The doc corrections are proven from source code and safe to merge.