Skip to content

fix(verify): correct doc drift in TR-08 verification skill #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mite404 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(verify): correct doc drift in TR-08 verification skill #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/verify-tr-08/features/playback-controls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Evidence is preserved at `/tmp/tr-08-verify-playback-test/`.

2. **Sample loading:** On first play, all audio samples are loaded asynchronously. The app shows a loading state while samples load. The control script's `wait-settle` command waits for this, but you may need to add extra delay if samples are slow to load.

3. **BPM bounds:** The UI clamps BPM between 40 and 300. Clicking bpm-up at 300 or bpm-down at 40 does nothing.
3. **BPM bounds:** The BPM type enforces 40-300 range at the data layer (Zod schema), but the UI increment/decrement handlers don't clamp. You can increment past 300 or decrement below 40 in the UI, though the values will fail validation when saving to Supabase.

4. **Playhead wraps:** After step 15, the playhead wraps back to step 0 and the loop repeats indefinitely until stopped.

Expand Down
4 changes: 2 additions & 2 deletions .agents/skills/verify-tr-08/features/track-controls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Per-track controls for muting, soloing, adjusting volume/pitch, and clearing pat

1. **Mute:** Silence a track (visual feedback: button state changes)
2. **Solo:** Play only soloed tracks (mutes all others)
3. **Volume:** Per-track volume knob (-60 to +6 dB, default: -5 dB)
3. **Volume:** Per-track volume knob (-45 to +5 dB, default: -5 dB)
4. **Pitch:** Per-track pitch knob (-12 to +12 semitones, default: 0)
5. **Clear:** Clear all steps and accents for a track (keeps other settings)

Expand Down Expand Up @@ -70,7 +70,7 @@ async function setVolume(trackIndex, dbValue) {

3. **Solo interaction:** When any track is soloed, all other tracks are effectively muted. Soloing multiple tracks means only those soloed tracks play. This can be confusing to verify without audio capture.

4. **Volume/pitch ranges:** Volume is -60 to +6 dB (66 dB range). Pitch is -12 to +12 semitones (24 semitone range). Knob rotation maps these ranges to a 0-1 normalized value internally.
4. **Volume/pitch ranges:** Volume is -45 to +5 dB (50 dB range). Pitch is -12 to +12 semitones (24 semitone range). Knob rotation maps these ranges to a 0-1 normalized value internally.

5. **Clear is destructive:** The clear button removes all steps and accents for that track. There is no undo (except reloading a saved beat).

Expand Down