Add timeout and retry logic to senedd regmem - #259
Open
ajparsons wants to merge 1 commit into
Open
Conversation
dracos
requested changes
Jul 2, 2026
| time.sleep(10) | ||
| # Get fresh content for the retry | ||
| content = requests.get(url, headers=headers).content | ||
| content = fetch_url(url) |
Member
There was a problem hiding this comment.
The while loop is now feching it twice - I don't think this line is needed at all, if the fetch_url is now the first bit of the while
Member
There was a problem hiding this comment.
Also, if fetch_url itself now has a loop, we probably don't want another loop here at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes this hangs! This adds some delay and retry logic, and if not, should just fail.