Repository navigation
fix(console): an injected @objectstack/client joins the vendor-objectstack chunk group (objectui#10920) - #10921
Merged
objectstack-fleet[bot] merged 2 commits intoSep 28, 2026
Conversation
…stack chunk group objectstack's build-console.sh always injects its own client through OBJECTSTACK_CLIENT_DIST, from a workspace path the vendor-objectstack test does not match. Since #9488 made data-adapter non-recursive, the client fell into `framework`, closing a framework <-> data-adapter import cycle; the client ships as CJS, so data-adapter's top-level require ran before `framework` defined it and the console died at boot with "TypeError: u is not a function" (measured on 9f0c84a). widenVendorChunkTestForClient widens the group's test with the injected package directory, the same way the spec hook already does for an injected spec. With it, chunk-membership.json reads client -> vendor-objectstack and the console boots. Claude-Session: https://claude.ai/code/session_local_f929252f-7e71-4327-b98b-bd46424b5e05 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
|
changeset-claim-re-read
|
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
…client-vendor-chunk
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
objectstack-fleet
Bot
deleted the
claude/issue-10920-client-vendor-chunk
branch
September 28, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10920
What broke
objectstack's
build-console.shalways setsOBJECTSTACK_CLIENT_DISTto the framework's ownpackages/client. That path is outsidenode_modules, so thevendor-objectstackgroup test never matched the injected client. Before #9488 the recursivedata-adaptergroup absorbed the client anyway, which hid the gap. Once #9488 madedata-adapternon-recursive, the client landed inframework.frameworkimportsdata-adapter, throughpackages/react'serror-message.ts.data-adapterthenrequires the CJS client fromframeworkat its top level, beforeframeworkhas defined it. On9f0c84a44the console built this way stays on the splash screen withTypeError: u is not a function.The fix
widenVendorChunkTestForClientwidens the group's test with the injected client's package directory. The spec hook already does the same for an injected spec. When nothing is injected, the test is returned unchanged, so production and CI builds do not move.Evidence
vendorObjectstackTestwired back to the bare expression, only the config-level case fails (1 red, 21 green). That case is the one that pins the wiring.pnpm exec vitest run scripts/__tests__/vite-objectstack-client-dist.test.ts: 22 passed.pnpm type-check:scriptsandpnpm type-check:vitest-config: clean.node scripts/check-changeset-presence.mjs: no changeset is owed, because no published source moved.9f0c84a44:chunk-membership.jsonreadsclient: { "vendor-objectstack": 1 }, the console boots to/login, and a 95-surface sweep of the showcase and Setup apps shows no page errors.Generated by Claude Code