Replace hardcoded bare-metal root password with CHANGEME placeholder - #793
Open
Dyrkon wants to merge 1 commit into
Open
Replace hardcoded bare-metal root password with CHANGEME placeholder#793Dyrkon wants to merge 1 commit into
Dyrkon wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Dyrkon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Dyrkon
force-pushed
the
security/remove-hardcoded-credentials
branch
from
August 3, 2026 07:40
4e39cc4 to
b113e2c
Compare
mrkisaolamb
requested changes
Aug 4, 2026
mrkisaolamb
left a comment
mrkisaolamb
left a comment
There was a problem hiding this comment.
We are missing changes in examples/dt/nfv/nfv-ovs-dpdk-sriov-hci/dataplane-pre-ceph.md , examples/dt/nfv/nfv-ovs-dpdk-sriov-2nodesets/dataplane.md and examples/dt/perfscale/scalelab/dataplane.md ?
| cd architecture/examples/va/nvidia-mdev/edpm | ||
| ``` | ||
|
|
||
| Modify the [baremetalset-password.env](../../../dt/nova/nova04delta/edpm/nodeset/baremetalset-password.env) with a secure root password for bare-metal provisioning: |
| cd examples/dt/nfv/nfv-ovs-dpdk-sriov-networker | ||
| ``` | ||
|
|
||
| Modify the [baremetalset-password.env](../../../va/nfv/ovs-dpdk-sriov/edpm/nodeset/baremetalset-password.env) and [baremetalset-password.env](../../../va/nfv/ovs-dpdk-sriov/edpm/networker-nodeset/baremetalset-password.env) with a secure root password for bare-metal provisioning: |
There was a problem hiding this comment.
this should be ../../../../ I think
| cd architecture/examples/dt/nova/nova01alpha/edpm/ | ||
| ``` | ||
|
|
||
| Modify the [baremetalset-password.env](../../../dt/nova/nova01alpha/edpm/nodeset/baremetalset-password.env) with a secure root password for bare-metal provisioning: |
There was a problem hiding this comment.
this should be ../../../../ I think
| cd architecture/examples/dt/nova/nova02beta/edpm/ | ||
| ``` | ||
|
|
||
| Modify the [baremetalset-password.env](../../../dt/nova/nova02beta/edpm/nodeset/baremetalset-password.env) and [baremetalset-password.env](../../../dt/nova/nova02beta/edpm/nodeset2/baremetalset-password.env) with a secure root password for bare-metal provisioning: |
There was a problem hiding this comment.
this should be ../../../../ I think
| @@ -9,7 +9,6 @@ metadata: | |||
| config.kubernetes.io/local-config: "true" | |||
| data: | |||
| # Mapped in dt/nova/nova04delta/edpm/nodeset/kustomization.yaml to baremetalset-password-secret.data.NodeRootPassword | |||
Dyrkon
force-pushed
the
security/remove-hardcoded-credentials
branch
from
August 4, 2026 10:18
b113e2c to
bd2ed1e
Compare
Removed hardcoded redhat password (CWE-798) from 18 values.yaml files and converted to .env file pattern following bmo01 approach. Operators must now set a secure password in baremetalset-password.env before deployment. Updated 10 deployment docs to document the new requirement. Closes: OSPRH-33539 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Dyrkon
force-pushed
the
security/remove-hardcoded-credentials
branch
from
August 4, 2026 10:20
bd2ed1e to
02587c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed hardcoded redhat password (CWE-798) from 18 values.yaml files and converted to .env file pattern following bmo01 approach. Operators must now set a secure password in baremetalset-password.env before deployment. Updated 10 deployment docs to document the new requirement.
Closes: OSPRH-33539