Skip to content

Replace hardcoded bare-metal root password with CHANGEME placeholder #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dyrkon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace hardcoded bare-metal root password with CHANGEME placeholder #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions dt/nfv/nfv-ovs-dpdk-sriov-hci/edpm-pre-ceph/nodeset/baremetalset-password-secret.yaml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dt/nfv/nfv-ovs-dpdk-sriov-hci/edpm-pre-ceph/nodeset/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
22 changes: 8 additions & 14 deletions dt/nfv/nfv-ovs-dpdk-sriov-hci/edpm-pre-ceph/nodeset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,21 @@ transformers:
kind: Namespace
create: true

secretGenerator:
- name: baremetalset-password-secret
behavior: create
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

components:
- ../../../../../lib/dataplane/nodeset

resources:
- baremetalset-password-secret.yaml
- nova_ovs_dpdk_sriov.yaml

replacements:
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true

# Nova compute CPU pinning customization
- source:
kind: ConfigMap
Expand Down
9 changes: 0 additions & 9 deletions dt/nova/nova01alpha/edpm/nodeset/baremetalset-password-secret.yaml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dt/nova/nova01alpha/edpm/nodeset/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
22 changes: 8 additions & 14 deletions dt/nova/nova01alpha/edpm/nodeset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,21 @@ transformers:
kind: Namespace
create: true

secretGenerator:
- name: baremetalset-password-secret
behavior: create
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

components:
- ../../../../../lib/dataplane/nodeset

resources:
- baremetalset-password-secret.yaml
- nova_sriov.yaml

replacements:
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true

# Nova compute CPU pinning customization
- source:
kind: ConfigMap
Expand Down
9 changes: 0 additions & 9 deletions dt/nova/nova02beta/edpm/nodeset/baremetalset-password-secret.yaml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dt/nova/nova02beta/edpm/nodeset/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
22 changes: 8 additions & 14 deletions dt/nova/nova02beta/edpm/nodeset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,21 @@ transformers:
kind: Namespace
create: true

secretGenerator:
- name: baremetalset-password-secret
behavior: create
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

components:
- ../../../../../lib/dataplane/nodeset

resources:
- baremetalset-password-secret.yaml
- nova_sriov.yaml

replacements:
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true

# Nova compute CPU pinning customization
- source:
kind: ConfigMap
Expand Down
9 changes: 0 additions & 9 deletions dt/nova/nova02beta/edpm/nodeset2/baremetalset-password-secret.yaml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dt/nova/nova02beta/edpm/nodeset2/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
22 changes: 8 additions & 14 deletions dt/nova/nova02beta/edpm/nodeset2/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,21 @@ transformers:
kind: Namespace
create: true

secretGenerator:
- name: baremetalset-password-secret
behavior: create
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

components:
- ../../../../../lib/dataplane/nodeset

resources:
- baremetalset-password-secret.yaml
- nova_sriov.yaml

replacements:
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true

# Nova compute CPU pinning customization
- source:
kind: ConfigMap
Expand Down
1 change: 1 addition & 0 deletions dt/nova/nova04delta/edpm/nodeset/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
17 changes: 2 additions & 15 deletions dt/nova/nova04delta/edpm/nodeset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ transformers:
secretGenerator:
- name: baremetalset-password-secret
behavior: create
literals:
- NodeRootPassword=redhat
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

Expand Down Expand Up @@ -83,19 +83,6 @@ replacements:
- spec.baremetalSetTemplate
options:
create: true
# BMO root password for provisioned host
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true
# BMO networkData for provisioned host
- source:
kind: ConfigMap
Expand Down
1 change: 1 addition & 0 deletions dt/nova/nova05epsilon/edpm-pre-ceph/nodeset/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
17 changes: 2 additions & 15 deletions dt/nova/nova05epsilon/edpm-pre-ceph/nodeset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ transformers:
secretGenerator:
- name: baremetalset-password-secret
behavior: create
literals:
- NodeRootPassword=redhat
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

Expand Down Expand Up @@ -92,19 +92,6 @@ replacements:
- spec.baremetalSetTemplate
options:
create: true
# BMO root password for provisioned host
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true
# BMO networkData for provisioned host
- source:
kind: ConfigMap
Expand Down
1 change: 1 addition & 0 deletions dt/perfscale/scalelab/edpm/nodeset/baremetalset-password.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NodeRootPassword=CHANGEME
22 changes: 8 additions & 14 deletions dt/perfscale/scalelab/edpm/nodeset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ transformers:
kind: Namespace
create: true

secretGenerator:
- name: baremetalset-password-secret
behavior: create
envs:
- baremetalset-password.env
options:
disableNameSuffixHash: true

components:
- ../../../../../lib/dataplane/nodeset

Expand All @@ -27,17 +35,3 @@ patches:
patch: |
- op: remove
path: /data/authorized_keys

replacements:
- source:
kind: ConfigMap
name: edpm-nodeset-values
fieldPath: data.root_password
targets:
- select:
kind: Secret
name: baremetalset-password-secret
fieldPaths:
- data.NodeRootPassword
options:
create: true
1 change: 0 additions & 1 deletion examples/dt/nfv/nfv-ovs-dpdk-sriov-2nodesets/edpm/nodeset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nfv/nfv-ovs-dpdk-sriov-2nodesets/edpm/nodeset2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nfv/nfv-ovs-dpdk-sriov-hci/edpm-pre-ceph/nodeset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
5 changes: 5 additions & 0 deletions examples/dt/nfv/nfv-ovs-dpdk-sriov-networker/dataplane.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ Change to the `nfv/nfv-ovs-dpdk-sriov-networker/edpm directory:
cd examples/dt/nfv/nfv-ovs-dpdk-sriov-networker
```

Modify the [baremetalset-password.env](../../../../va/nfv/ovs-dpdk-sriov/edpm/nodeset/baremetalset-password.env) and [baremetalset-password.env](../../../../va/nfv/ovs-dpdk-sriov/edpm/networker-nodeset/baremetalset-password.env) with a secure root password for bare-metal provisioning:
```
NodeRootPassword=YourSecurePasswordHere
```

Edit the [edpm/computes/values.yaml](edpm/computes/values.yaml),
[edpm/networkers/values.yaml](edpm/networkers/values.yaml) and
[edpm/deployment/values.yaml](edpm/deployment/values.yaml) files to suit your
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nfv/nfv-ovs-dpdk-sriov-networker/edpm/computes/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nfv/nfv-ovs-dpdk-sriov-networker/edpm/networkers/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
6 changes: 6 additions & 0 deletions examples/dt/nova/nova01alpha/dataplane.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ Change to the nova/nova01alpha/edpm directory
```
cd architecture/examples/dt/nova/nova01alpha/edpm/
```

Modify the [baremetalset-password.env](../../../../dt/nova/nova01alpha/edpm/nodeset/baremetalset-password.env) with a secure root password for bare-metal provisioning:
```
NodeRootPassword=YourSecurePasswordHere
```

Edit the [nodeset/values.yaml](edpm/nodeset/values.yaml) and [deployment/values.yaml](edpm/deployment/values.yaml) files to suit
your environment.
```
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nova/nova01alpha/edpm/nodeset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
6 changes: 6 additions & 0 deletions examples/dt/nova/nova02beta/dataplane.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ Change to the nova/nova02beta/edpm directory
```
cd architecture/examples/dt/nova/nova02beta/edpm/
```

Modify the [baremetalset-password.env](../../../../dt/nova/nova02beta/edpm/nodeset/baremetalset-password.env) and [baremetalset-password.env](../../../../dt/nova/nova02beta/edpm/nodeset2/baremetalset-password.env) with a secure root password for bare-metal provisioning:
```
NodeRootPassword=YourSecurePasswordHere
```

Edit the [nodeset/values.yaml](edpm/nodeset/values.yaml), the [nodeset2/values.yaml](edpm/nodeset2/values.yaml),
and [deployment/values.yaml](edpm/deployment/values.yaml) files to suit
your environment.
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nova/nova02beta/edpm/nodeset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
1 change: 0 additions & 1 deletion examples/dt/nova/nova02beta/edpm/nodeset2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
annotations:
config.kubernetes.io/local-config: "true"
data:
root_password: cmVkaGF0Cg==
preProvisioned: false
baremetalSetTemplate:
ctlplaneInterface: eno2 # CHANGEME
Expand Down
Loading