Skip to content

OSAC-1469: drop stale PublicIP reference from AGENTS.md - #253

Open
SiddarthR56 wants to merge 1 commit into
osac-project:mainfrom
SiddarthR56:OSAC-1469
Open

OSAC-1469: drop stale PublicIP reference from AGENTS.md#253
SiddarthR56 wants to merge 1 commit into
osac-project:mainfrom
SiddarthR56:OSAC-1469

Conversation

@SiddarthR56

@SiddarthR56 SiddarthR56 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Removes a stale `PublicIP` mention from `osac-operator/AGENTS.md`'s Provisioning section, replacing it with `ExternalIP` (the family of controllers this text actually describes). The generated Go bindings for the PublicIP/PublicIPPool/PublicIPAttachment private v1 types and services were already removed earlier in OSAC-2872 (bump osac-operator BSR to v0.0.85, commit 1bc8491) — this PR is a docs-only follow-up cleaning up the leftover reference, not a code/bindings removal.

Summary by CodeRabbit

  • Documentation
    • Updated provisioning guidance to include ExternalIP controllers alongside networking controllers.
    • Replaced outdated PublicIP terminology with ExternalIP.

@openshift-ci-robot

openshift-ci-robot commented Aug 11, 2026

Copy link
Copy Markdown

@SiddarthR56: This pull request references OSAC-1469 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Deletes the generated Go bindings for the PublicIP/PublicIPPool/ PublicIPAttachment private v1 types and services, and updates AGENTS.md to drop the now-removed PublicIP reference alongside ExternalIP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 777ab3ac-52c3-4586-95e5-5bcede1d9753

📥 Commits

Reviewing files that changed from the base of the PR and between d6db992 and 81d7419.

📒 Files selected for processing (1)
  • osac-operator/AGENTS.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • osac-operator/AGENTS.md

Walkthrough

The provisioning documentation now refers to the ExternalIP controller family instead of the former PublicIP/ExternalIP terminology.

Changes

Provisioning documentation

Layer / File(s) Summary
ExternalIP controller terminology
osac-operator/AGENTS.md
The provisioning overview identifies the ExternalIP controller family and removes the former PublicIP terminology.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: larsks, rccrdpccl

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning The PR commit includes Co-authored-by: Cursor <cursoragent@cursor.com> and no Assisted-by or Generated-by trailer; this violates the AI attribution rule. Amend the commit to remove the AI Co-authored-by trailer and add the required Red Hat Assisted-by or Generated-by trailer.
✅ Passed checks (10 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The parent-to-HEAD diff changes only AGENTS.md terminology; the added line contains no API key, token, password, credential, private key, or credential-shaped URL.
No-Weak-Crypto ✅ Passed The PR diff changes only osac-operator/AGENTS.md; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison usage.
No-Injection-Vectors ✅ Passed The PR diff changes only one AGENTS.md documentation line; the added-line scan found no SQL, shell, eval/exec, pickle, unsafe YAML, or dangerouslySetInnerHTML vector.
Container-Privileges ✅ Passed The commit changes only one AGENTS.md documentation line; it adds no container or Kubernetes manifest and no listed privilege setting.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only a documentation term in AGENTS.md. It adds no logging calls, log fields, credentials, tokens, or other sensitive data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the documented AGENTS.md change, although it does not mention the removal of unused PublicIP bindings.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, SiddarthR56

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 12, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:43 PM UTC · Completed 3:52 PM UTC

Commit: 81d7419 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 12, 2026

Copy link
Copy Markdown

Looks good to me

Previous run

Looks good to me


Labels: PR modifies documentation only (AGENTS.md terminology update removing outdated PublicIP reference)

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge documentation Improvements or additions to documentation labels Aug 12, 2026
Deletes the generated Go bindings for the PublicIP/PublicIPPool/
PublicIPAttachment private v1 types and services, and updates
AGENTS.md to drop the now-removed PublicIP reference alongside
ExternalIP.

Co-authored-by: Cursor <cursoragent@cursor.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 13, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:06 AM UTC · Completed 7:14 AM UTC

Commit: 002e5fc · View workflow run →

@SiddarthR56 SiddarthR56 changed the title OSAC-1469: remove unused PublicIP generated proto code OSAC-1469: drop stale PublicIP reference from AGENTS.md Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved documentation Improvements or additions to documentation jira/valid-reference ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants