Skip to content

OSAC-1469: drop stale PublicIP reference from AGENTS.md #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SiddarthR56 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

OSAC-1469: drop stale PublicIP reference from AGENTS.md #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osac-operator/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Each resource has a **resource controller** (provisions via AAP, manages finaliz

### Provisioning

ClusterOrder and ComputeInstance controllers use direct AAP REST API integration via the `ProvisioningProvider` interface (`pkg/provisioning/provider.go` and `pkg/aap/client.go`). Networking controllers (VirtualNetwork, Subnet, SecurityGroup) and the PublicIP/ExternalIP family of controllers also use this pattern. `pkg/provisioning`, `pkg/aap`, and `pkg/dispatcher` are public packages consumed outside this repo (e.g., `bare-metal-fulfillment-operator`) — changes to their interfaces can impact those consumers. `pkg/dispatcher.NetworkClassClient` is the seam other operators implement to resolve a NetworkClass's fabric/k8s managers without depending on this repo's `internal/api` gRPC client; `internal/dispatcheradapter` is this repo's own implementation, wrapping the generated `privatev1.NetworkClassesClient`. Management-state annotation (`osac.openshift.io/management-state = Unmanaged`) is checked by every resource controller except `tenant_controller.go` to skip reconciliation.
ClusterOrder and ComputeInstance controllers use direct AAP REST API integration via the `ProvisioningProvider` interface (`pkg/provisioning/provider.go` and `pkg/aap/client.go`). Networking controllers (VirtualNetwork, Subnet, SecurityGroup) and the ExternalIP family of controllers also use this pattern. `pkg/provisioning`, `pkg/aap`, and `pkg/dispatcher` are public packages consumed outside this repo (e.g., `bare-metal-fulfillment-operator`) — changes to their interfaces can impact those consumers. `pkg/dispatcher.NetworkClassClient` is the seam other operators implement to resolve a NetworkClass's fabric/k8s managers without depending on this repo's `internal/api` gRPC client; `internal/dispatcheradapter` is this repo's own implementation, wrapping the generated `privatev1.NetworkClassesClient`. Management-state annotation (`osac.openshift.io/management-state = Unmanaged`) is checked by every resource controller except `tenant_controller.go` to skip reconciliation.

### Multi-cluster

Expand Down
Loading