Skip to content

fix(update): avoid flaky timestamp assertions - #968

Merged
ryanfowler merged 1 commit into
mainfrom
fix/macos-update-test-flake
Aug 8, 2026
Merged

fix(update): avoid flaky timestamp assertions#968
ryanfowler merged 1 commit into
mainfrom
fix/macos-update-test-flake

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • compare executable inode identity after self-update instead of modification timestamps
  • keep timestamp assertions for no-op and dry-run update cases
  • avoid macOS CI flakes when replacement files receive identical timestamps

Validation

  • cargo fmt --check
  • cargo test --locked --all-features --test update
  • cargo test --locked --all-features --lib --bins

Caveat

  • Full clippy currently fails on an unrelated existing dead-code warning in src/dns/wire.rs.

@ryanfowler
ryanfowler enabled auto-merge August 8, 2026 10:09
@ryanfowler
ryanfowler merged commit 17a1b61 into main Aug 8, 2026
4 checks passed
@ryanfowler
ryanfowler deleted the fix/macos-update-test-flake branch August 8, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant