Skip to content

fix(update): avoid flaky timestamp assertions #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanfowler merged 1 commit into from
Aug 8, 2026
Merged

fix(update): avoid flaky timestamp assertions #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions tests/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
mod support;

use std::fs;
use std::os::unix::fs::MetadataExt;
use std::path::Path;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Arc, Mutex};
Expand All @@ -14,6 +15,10 @@ use support::update::{
};
use tempfile::TempDir;

fn file_id(path: &Path) -> u64 {
fs::metadata(path).unwrap().ino()
}

#[cfg(not(windows))]
#[test]
fn self_update_go_harness_cases() {
Expand Down Expand Up @@ -57,6 +62,7 @@ fn self_update_go_harness_cases() {
};

let original_modified = fs::metadata(&update_bin).unwrap().modified().unwrap();
let original_file_id = file_id(&update_bin);
let res = run_fetch_opts(opts(&update_bin, env.clone()), &[&server.url, "--update"]);
assert_exit(&res, 0);
assert!(res.stderr.contains("Already using the latest version"));
Expand Down Expand Up @@ -131,17 +137,14 @@ fn self_update_go_harness_cases() {
2,
"unexpected update temp files"
);
assert_ne!(
fs::metadata(&update_bin).unwrap().modified().unwrap(),
original_modified
);
assert_ne!(file_id(&update_bin), original_file_id);

let res = run_fetch_opts(opts(&update_bin, env.clone()), &["--version"]);
assert_exit(&res, 0);
assert!(res.stdout.contains("fetch v999.0.0-test"));

*latest_version.lock().unwrap() = "v1000.0.0-test".to_string();
let auto_update_modified = fs::metadata(&auto_update_bin).unwrap().modified().unwrap();
let auto_update_file_id = file_id(&auto_update_bin);
let mut sync_auto_update_env = env.clone();
sync_auto_update_env.push((
"FETCH_INTERNAL_SYNC_AUTO_UPDATE".to_string(),
Expand All @@ -152,10 +155,7 @@ fn self_update_go_harness_cases() {
&[&server.url, "--auto-update", "0s"],
);
assert_exit(&res, 0);
assert_ne!(
fs::metadata(&auto_update_bin).unwrap().modified().unwrap(),
auto_update_modified
);
assert_ne!(file_id(&auto_update_bin), auto_update_file_id);

let res = run_fetch_opts(opts(&auto_update_bin, env), &["--version"]);
assert_exit(&res, 0);
Expand Down Expand Up @@ -205,7 +205,7 @@ fn auto_update_preserves_explicit_config_proxy() {

let config = dir.path().join("config");
fs::write(&config, format!("format = off\nproxy = {}\n", proxy.url)).unwrap();
let before_modified = fs::metadata(&auto_update_bin).unwrap().modified().unwrap();
let before_file_id = file_id(&auto_update_bin);
let res = run_fetch_opts(
FetchOpts {
bin: Some(auto_update_bin.clone()),
Expand All @@ -229,10 +229,7 @@ fn auto_update_preserves_explicit_config_proxy() {
assert_exit(&res, 0);
assert_eq!(res.stdout, "primary ok");
assert_eq!(update_requests.load(Ordering::SeqCst), 3);
assert_ne!(
fs::metadata(&auto_update_bin).unwrap().modified().unwrap(),
before_modified
);
assert_ne!(file_id(&auto_update_bin), before_file_id);

let res = run_fetch_opts(
FetchOpts {
Expand Down
Loading