DAB: Fix some styling and spacing bugs - #1087
Conversation
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughLexicon layouts, navigation, entry rendering, and search views now use reactive theme colors instead of CSS variables. Entry XML handling also preserves text whitespace, renders vernacular links as anchors, and moves audio-link styling into component styles. ChangesLexicon theme rendering
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/lexicon/components/EntryView.svelte`:
- Around line 73-75: Update processNode to discard whitespace-only text nodes
before rendering inside <pre>, while preserving text nodes containing meaningful
mixed-content whitespace. Keep returning the original node value for
non-whitespace text and leave element processing unchanged.
- Around line 106-107: Update the generated anchor in the match/hash-link branch
to retain a sanitized href for normal and hash links, preserving navigation and
keyboard activation. For synthetic E-n links without a usable href, provide the
existing accessible activation behavior and prevent default navigation as
needed, while keeping the current link text and data attributes.
- Around line 187-188: Update the `$effect` that builds `xmlData` to
synchronously capture `$themeColors['SettingsSeparatorColor']` before the
asynchronous `queryXmlByWordId` call, then pass that captured value into
`updateXmlData`. Ensure the effect tracks theme changes so separator colors are
regenerated after the theme updates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ff25540c-6e46-487a-ad2f-6ce94828385b
📒 Files selected for processing (5)
src/lib/lexicon/components/EntryView.sveltesrc/lib/lexicon/components/WordNavigationStrip.sveltesrc/routes/lexicon/+layout.sveltesrc/routes/lexicon/+page.sveltesrc/routes/lexicon/search/+page.svelte
Summary by CodeRabbit
Style
Bug Fixes