Add design and investigation docs for Issue #58 (Excel template support) and update task tracking - #59
Conversation
…y and functionality - Added new SVG assets for target cell values and style overflow modes to enhance visual representation of Excel templates. - Updated design documentation to reflect changes in handling optional destination styles and column overflow behavior. - Included detailed reports addressing user feedback on template structure, style options, and SVG formatting. - Enhanced clarity on the behavior of group blocks and their interaction with overflow scenarios. - Restored and refined SVG formats to align with actual design rules and user expectations.
…0, consolidating parent frame to A3:E10
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 554ae7544c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cell.Reference, | ||
| cell.Row, | ||
| cell.Column, |
There was a problem hiding this comment.
Component items are emitted with the source sheet's absolute row/column values even after filtering to the resolved component range. If a component range starts away from A1 (for example C5:D8), the first component cell is serialized as r="5" c="3", so <use r="1" c="1"> places content at the wrong offset instead of anchoring at (1,1) inside the component grid. The output item coordinates should be normalized relative to the component range's top-left cell before serialization.
Useful? React with 👍 / 👎.
| if (updatedHeads.Add(existingHead)) | ||
| { | ||
| mergedCells[existingIndex] = AppendStyleToCell(existingCell, seedCell.StylePlan); | ||
| } |
There was a problem hiding this comment.
When a seed style cell falls inside an existing merged layout cell, this path applies only the first seed style per merged-cell head and skips the rest. That drops side-specific border contributions (especially from mode="outer" expansion), so merged cells can lose bottom/right edges when a <use> style is applied across multiple seed coordinates. The merge logic needs to accumulate style overlays from every covered seed coordinate, not just the first one.
Useful? React with 👍 / 👎.
1 participant
Motivation
Excel -> XmlTemplate -> DSLdebugging path and aExcel -> DSLproduction path before implementation.Description
Design/Issue58/Issue58_DetailDesign.mdcontaining the detailed design, phased rollout, architecture diagram, new components (ExcelTemplateExtractor,XmlTemplateSerializer,DslEmitter), DSL mapping rules (sheet-based__component_<Name>), failure policy, and test strategy.reports/issue58-investigation-2026-04-07.mdthat documents how the issue body was obtained (including therggrep command and direct GitHub Issue URL lookup) and summarizes the issue requirements.tasks/feedback-points.mdto addFP110andFP111and bumpLast Updatedto2026-04-07, and updatetasks/phases-status.mdandtasks/tasks-status.mdwith new entries noting the investigation and creation of the draft design awaiting approval.Testing
Codex Task