accelerate CI via cargo binstall#2209
Open
plebhash wants to merge 3 commits into
Open
Conversation
9b277f9 to
bdfad1f
Compare
GitGab19
reviewed
Jun 22, 2026
GitGab19
left a comment
Member
There was a problem hiding this comment.
One nit found by my clanker, which pins the version for real.
Without it, the action still downloads the latest it seems: https://github.com/stratum-mining/stratum/actions/runs/27847218527/job/82418833360?pr=2209#step:5:35
bdfad1f to
6a3cc9d
Compare
GitGab19
approved these changes
Jun 23, 2026
Shourya742
reviewed
Jun 23, 2026
|
|
||
| # Install cargo-binstall so tool installs below use prebuilt binaries. | ||
| - name: Install cargo-binstall | ||
| uses: cargo-bins/cargo-binstall@v1.20.0 |
Member
There was a problem hiding this comment.
Is this version beside binstall required anymore, considering now we have with version attribute? I think we can remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accelerate CI via
cargo-binstallinstead of compiling
cargo-nextest,cargo-semver-checks, andcargo-fuzzon every run, we install pre-built binaries viacargo-binstall.additional hardening:
quick-installoption to only use upstream release artifacts (instead of third-party quick-install artifacts)GITHUB_TOKENtocargo-binstallto avoid unauthenticated GitHub API rate-limit fallback--lockedfor deterministic fallback behavior if source install is ever neededestimated impact (latest successful PR run vs median of 5 recent comparable successful PR runs on the same workflows/jobs):
ci (ubuntu-latest):~2m33s -> ~2s(~99% reduction)~31m27s -> ~29m05s(~2m22s faster, ~8%)ci (macos-latest):~2m18s -> ~4s(~97% reduction)~30m16s -> ~29m01s(~1m15s faster, ~4%)semver-check:~3m53s -> ~2s(~99% reduction)~7m12s -> ~3m17s(~3m55s faster, ~54%)fuzz:~20s -> ~2s(~90% reduction)~1m14s -> ~1m01s(~13s faster, ~18%)critical-path wall clock improves (
~31m27s -> ~29m05s, ~2m22s), while matrix jobs still run in parallel.