Skip to content

accelerate CI via cargo binstall #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plebhash wants to merge 3 commits into
base: main
Choose a base branch
from
+46 −7
Open

accelerate CI via cargo binstall #2209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c45f802
ci: install cargo-semver-checks via cargo-binstall
plebhash Jun 16, 2026
c7c1d96
ci: install cargo-nextest via cargo-binstall
plebhash Jun 16, 2026
6a3cc9d
ci: install cargo-fuzz via cargo-binstall
plebhash Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions .github/workflows/fuzz_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,18 @@ jobs:
run: |
rustup override set ${{ steps.toolchain.outputs.name }}

# Install cargo-binstall so tool installs below use prebuilt binaries.
- name: Install cargo-binstall
uses: cargo-bins/cargo-binstall@v1.20.0
Comment thread
GitGab19 marked this conversation as resolved.

@Shourya742 Shourya742 Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this version beside binstall required anymore, considering now we have with version attribute? I think we can remove it

with:
version: "1.20.0"

# Install cargo-fuzz via cargo-binstall (no source build).
# Keep quick-install disabled to only use upstream release artifacts.
- name: Install cargo-fuzz
run: cargo install cargo-fuzz
env:
GITHUB_TOKEN: ${{ github.token }}
run: cargo binstall --no-confirm --disable-telemetry --disable-strategies quick-install --locked cargo-fuzz

- name: Checkout fuzzing corpus
uses: actions/checkout@v4
Expand All @@ -36,6 +46,16 @@ jobs:

- name: Run fuzz regressions
run: |
# cargo-fuzz binaries installed via cargo-binstall can default to a
# musl target triple; derive the runner's rustc host triple so
# sanitizer builds run against the native target instead.
HOST_TARGET="$(rustc -vV | sed -n 's/^host: //p')"

if [ -z "$HOST_TARGET" ]; then
echo "Failed to detect rustc host target" >&2
exit 1
fi

for TARGET in $(cargo fuzz list); do
CORPUS_DIR="fuzz/repo-corpus/corpus/$TARGET"

Expand All @@ -47,6 +67,7 @@ jobs:
fi

echo "==> Running fuzz target: $TARGET"
cargo fuzz run "$TARGET" "$CORPUS_DIR" -- -runs=0 -max_total_time=30
# Keep target explicit to avoid sanitizer/libc mismatches when
# cargo-fuzz's bundled default target differs from the runner.
cargo fuzz run --target "$HOST_TARGET" "$TARGET" "$CORPUS_DIR" -- -runs=0 -max_total_time=30
done

13 changes: 11 additions & 2 deletions .github/workflows/integration-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,19 @@ jobs:
run: |
brew install capnp

# Install cargo-binstall so tool installs below use prebuilt binaries.
- name: Install cargo-binstall
uses: cargo-bins/cargo-binstall@v1.20.0
with:
version: "1.20.0"

# Install cargo-nextest via cargo-binstall (no source build).
# Keep quick-install disabled to only use upstream release artifacts.
- name: Install cargo-nextest
run: cargo install cargo-nextest --version 0.9.100 --locked
env:
GITHUB_TOKEN: ${{ github.token }}
run: cargo binstall --no-confirm --disable-telemetry --disable-strategies quick-install --locked cargo-nextest@0.9.100

- name: Run Integration Tests Script
if: steps.detect.outputs.should_run_integration_test == 'true'
run: ./scripts/run-integration-tests.sh

13 changes: 11 additions & 2 deletions .github/workflows/semver-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,18 @@ jobs:
- name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y cmake

# Install cargo-binstall so tool installs below use prebuilt binaries.
- name: Install cargo-binstall
uses: cargo-bins/cargo-binstall@v1.20.0
with:
version: "1.20.0"

# Install cargo-semver-checks via cargo-binstall (no source build).
# Keep quick-install disabled to only use upstream release artifacts.
- name: Install cargo-semver-checks
run: cargo install cargo-semver-checks --version 0.37.0 --locked
env:
GITHUB_TOKEN: ${{ github.token }}
run: cargo binstall --no-confirm --disable-telemetry --disable-strategies quick-install --locked cargo-semver-checks@0.37.0

- name: Run semver checks for sv2/buffer-sv2
working-directory: sv2/buffer-sv2
Expand Down Expand Up @@ -109,4 +119,3 @@ jobs:
- name: Run semver checks for stratum-core
working-directory: stratum-core
run: cargo semver-checks

Loading