feat: add request fields to ResourceLimits - #366
konstantinoscs merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
73d9bcf to
01afe20
Compare
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a public-API change to a public struct that can be semver-breaking for downstream consumers and needs an explicit compatibility/versioning decision.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds explicit request fields alongside existing limit fields in tower-runtime’s ResourceLimits model, enabling future backends/control-plane code to set both scheduling requests and enforced limits.
Changes:
- Extended
ResourceLimitswith CPU/memory/storage request fields. - Updated CLI execution-spec construction to populate the new fields.
- Updated runtime subprocess test fixtures to include the new fields.
File summaries
| File | Description |
|---|---|
| crates/tower-runtime/src/execution.rs | Extends the ResourceLimits public API to include request fields and updates inline docs. |
| crates/tower-cmd/src/run.rs | Updates local-run execution spec construction to set the new request fields. |
| crates/tower-runtime/tests/subprocess_test.rs | Updates test ExecutionSpec construction to include the new request fields. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
01afe20 to
7ae8313
Compare
This is a prerequisite to allow the control plane to dynamically set both request and resource limits