Skip to content

feat: add request fields to ResourceLimits - #366

Merged
konstantinoscs merged 1 commit into
developfrom
feature/tow-2721-add-request-fields-to-resource-limits
Sep 8, 2026
Merged

konstantinoscs merged 1 commit into
developfrom
feature/tow-2721-add-request-fields-to-resource-limits

Conversation

@konstantinoscs

@konstantinoscs konstantinoscs commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This is a prerequisite to allow the control plane to dynamically set both request and resource limits

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2ef8d1c9-1b5d-4057-9100-08afa002afc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@konstantinoscs
konstantinoscs force-pushed the feature/tow-2721-add-request-fields-to-resource-limits branch from 73d9bcf to 01afe20 Compare September 8, 2026 13:03
@konstantinoscs
konstantinoscs requested review from bradhe and socksy and a lite review from Copilot September 8, 2026 13:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces a public-API change to a public struct that can be semver-breaking for downstream consumers and needs an explicit compatibility/versioning decision.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds explicit request fields alongside existing limit fields in tower-runtime’s ResourceLimits model, enabling future backends/control-plane code to set both scheduling requests and enforced limits.

Changes:

  • Extended ResourceLimits with CPU/memory/storage request fields.
  • Updated CLI execution-spec construction to populate the new fields.
  • Updated runtime subprocess test fixtures to include the new fields.
File summaries
File Description
crates/tower-runtime/src/execution.rs Extends the ResourceLimits public API to include request fields and updates inline docs.
crates/tower-cmd/src/run.rs Updates local-run execution spec construction to set the new request fields.
crates/tower-runtime/tests/subprocess_test.rs Updates test ExecutionSpec construction to include the new request fields.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crates/tower-runtime/src/execution.rs
Comment thread crates/tower-runtime/src/execution.rs
@konstantinoscs
konstantinoscs force-pushed the feature/tow-2721-add-request-fields-to-resource-limits branch from 01afe20 to 7ae8313 Compare September 8, 2026 13:56
@konstantinoscs
konstantinoscs merged commit 4c0b7c5 into develop Sep 8, 2026
34 of 37 checks passed
@konstantinoscs
konstantinoscs deleted the feature/tow-2721-add-request-fields-to-resource-limits branch September 8, 2026 14:31
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants