Conversation
On Linux the HUD falls back to an 860x160 window because mouse passthrough is unsupported, so popovers opened above the toolbar were cut off. Resizing at runtime is unstable on Wayland (compositors ignore client positioning and the bar oscillates), so Wayland sessions now create the HUD pre-expanded. Co-Authored-By: claude-flow <ruv@ruv.net> Claude-Session: https://claude.ai/code/session_014WWof1pMnhBVJuJzNreUoB
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe HUD overlay now detects Linux Wayland sessions and forces fallback expansion during those sessions. The bounds calculation passes the detected session state, and tests cover Wayland detection and fallback behavior. ChangesWayland HUD overlay handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Wayland sessions now keep the HUD expanded to avoid compositor repositioning issues, while other platforms retain their existing behavior. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
On Linux the HUD falls back to a compact 860×160 window (mouse passthrough is not supported), so popovers that open above the toolbar (webcam, "more" menu, etc.) are clipped by the window bounds. On Wayland sessions the HUD is now created pre-expanded (860×540) and never resized at runtime.
Motivation
Resizing the HUD at runtime is unstable on Wayland: compositors ignore client-side positioning, so growing the window moves the bar away from the pointer (the approach in e2802bf was reverted for this reason). Creating the window at its expanded size avoids both the clipping and the oscillation. X11, Windows and macOS keep the current behaviour.
Type of Change
Related Issue(s)
Related to #891 and #772. Overlaps with the open PRs #876 and #919, which take a similar Wayland-gated approach — happy to close this in favour of whichever maintainers prefer.
Testing Guide
npm run devin a Wayland session (tested on GNOME Wayland, Ubuntu).npx vitest --run electron/hudOverlayBounds.test.tscovers Wayland detection and the always-expanded bounds.Known trade-off: on Linux the transparent part of the 860×540 window still captures clicks while the HUD is idle.
Checklist
🤖 Generated with claude-flow
https://claude.ai/code/session_014WWof1pMnhBVJuJzNreUoB
Summary by CodeRabbit