Update 3d-scene.js - #2
Open
iamsebastian wants to merge 1 commit into
Open
Conversation
Could not render scene/component without added interactions.
willviles
requested changes
Apr 7, 2017
willviles
left a comment
willviles
left a comment
Owner
There was a problem hiding this comment.
Thanks @iamsebastian. Just one review and then good to merge!
| let typeArr = get(this, `config.${type}`); | ||
|
|
||
| if (!typeArr || !(Array.isArray(typeArr))) { | ||
| console.info(`No instantiate of "${type}", due to not added objects of this type`); |
Owner
There was a problem hiding this comment.
I think we can allow this to return silently - no need for console.info!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could not render scene/component without added interactions.