Skip to content

Update 3d-scene.js #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamsebastian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 3d-scene.js #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion addon/components/3d-scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,14 @@ export default Ember.Component.extend({
// Setup objects.

instantiate(type) {
get(this, `config.${type}`).forEach((object) => {
let typeArr = get(this, `config.${type}`);

if (!typeArr || !(Array.isArray(typeArr))) {
console.info(`No instantiate of "${type}", due to not added objects of this type`);

@willviles willviles Apr 7, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can allow this to return silently - no need for console.info!

return;
}

typeArr.forEach((object) => {
let module = get(object, 'export');
if (typeOf(module) !== 'class') { return; }
module.create({
Expand Down