2/3 Add manual gRPC comparison test#165
Open
pacu wants to merge 1 commit into
Open
Conversation
Add framework support for starting lightwalletd and standalone zcashd fixtures, then add a manual gRPC parity test comparing zainod and lightwalletd responses. Include cached regtest fixtures and documentation so the test can run locally without rebuilding the fixture chain every time. Co-Authored-By: OpenAI Codex <codex@openai.com>
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack order:
grpc-comparison-ci->grpc-comparison-manual: run the gRPC comparison test in CI.Goal:
Add a manually runnable gRPC parity test that compares
zainodandlightwalletdresponses against the samezebradregtest chain, without enabling it in CI yet.What is included:
qa/rpc-tests/grpc_comparison.pyparity test.qa/zcash/grpc_comparison_tests.pyconvenience wrapper.lightwalletdand standalonezcashdfixture builders.qa/rpc-tests/cache/grpc_comparison*.Review focus:
This PR is where the handwritten test behavior lives. CI wiring is intentionally deferred to PR 3 so this diff can be reviewed on its own.
Local checks run:
python -m py_compile qa/rpc-tests/grpc_comparison.py qa/rpc-tests/test_framework/authproxy.py qa/rpc-tests/test_framework/config.py qa/rpc-tests/test_framework/test_framework.py qa/rpc-tests/test_framework/util.py qa/zcash/grpc_comparison_tests.pytimeout 900s uv run ./qa/zcash/grpc_comparison_tests.py --nocleanupNote:
The wrapper in this PR invokes
qa/rpc-tests/grpc_comparison.pydirectly so the manual test can run before PR 3 registers it inqa/pull-tester/rpc-tests.py.Co-Authored-By: OpenAI Codex codex@openai.com