Repository navigation
🤖 fix: Ctrl+I on the new-workspace screen, collapse button focus ring, actions tooltip name, fast mode feedback - #5744
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b00cc220f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…s ring, workspace actions tooltip, fast mode feedback
b00cc22 to
fd0a766
Compare
|
Readiness record for head
Generated with |
Summary
Four keyboard, focus and label fixes from the agent bug bash: Ctrl+I now focuses the composer on the new-workspace screen, the right sidebar's collapse button shows a focus ring, the workspace actions tooltip uses the button's accessible name, and the fast mode shortcut says why fast mode is unavailable instead of doing nothing.
Fixes #5687
Fixes #5688
Fixes #5681
Fixes #5693
Background
All four came from the agent bug bash in #5670.
FOCUS_CHAThandler was inuseAIViewKeybinds, which only the workspace view uses.SidebarCollapseButtonhad nofocus-visiblestyle, andglobals.cssremoves outlines.aria-label="Workspace actions", but its tooltip said "More actions".toggleFastModereturned early without feedback whengetFastModeProviderfound no fast mode route (for example a non-first-party Anthropic base URL).Implementation
FOCUS_CHATlistener with the same rules as the workspace one: it works from inputs, and it yields to remote desktops and open dialogs. Onlyvariant === "creation"registers it, so the workspace view keeps one handler.focus-visiblering with the accent color. Inset, because the sidebar clips anything drawn outside the button. The left sidebar uses the same shared button, so it gains the ring too.<model>on its current provider route, for example through a gateway or a custom base URL." It does not change any setting.Validation
New bug-bash repros in
tests/bugbash/repros/focusAndLabels.e2e.ts(4 tests, web and phone targets). On main each one fails on its own assertion:ASSERTION_FAILED: expect.toBeFocusedASSERTION_FAILED: expect.poll(...).not.toMatch(...), last:"none"ASSERTION_FAILED: expect.toHaveText, observed"More actions"ASSERTION_FAILED: expect.toBeVisibleWith the fix all 8 runs pass.
make test-bugbash-reprospasses, andmake test-bugbash-known-failuresfails the same tests as on main.Screenshots
Ctrl+I on the new-workspace screen. Before, focus stays on the page body:
After, the composer has focus:
Collapse button after Tab. Before, no ring:
After, an inset accent ring:
Workspace actions tooltip. Before:
After:
Ctrl+Shift+F with fast mode unavailable. Before, nothing:
After, a toast says why:
390 px width:
Risks
Low. Each change is local to one control or shortcut. The new Ctrl+I listener exists only while the creation composer is mounted.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high