Skip to content

🤖 fix: Ctrl+I on the new-workspace screen, collapse button focus ring, actions tooltip name, fast mode feedback - #5744

Merged
ThomasK33 merged 2 commits into
mainfrom
fix-focus-labels
Oct 6, 2026
Merged

ThomasK33 merged 2 commits into
mainfrom
fix-focus-labels

Conversation

@ThomasK33

Copy link
Copy Markdown
Member

Summary

Four keyboard, focus and label fixes from the agent bug bash: Ctrl+I now focuses the composer on the new-workspace screen, the right sidebar's collapse button shows a focus ring, the workspace actions tooltip uses the button's accessible name, and the fast mode shortcut says why fast mode is unavailable instead of doing nothing.

Fixes #5687
Fixes #5688
Fixes #5681
Fixes #5693

Background

All four came from the agent bug bash in #5670.

Implementation

Validation

New bug-bash repros in tests/bugbash/repros/focusAndLabels.e2e.ts (4 tests, web and phone targets). On main each one fails on its own assertion:

Repro Result on main
Ctrl+I on the new-workspace screen (#5687) ASSERTION_FAILED: expect.toBeFocused
collapse button focus ring (#5688) ASSERTION_FAILED: expect.poll(...).not.toMatch(...), last: "none"
actions tooltip (#5681) ASSERTION_FAILED: expect.toHaveText, observed "More actions"
fast mode feedback (#5693) ASSERTION_FAILED: expect.toBeVisible

With the fix all 8 runs pass. make test-bugbash-repros passes, and make test-bugbash-known-failures fails the same tests as on main.

Screenshots

Ctrl+I on the new-workspace screen. Before, focus stays on the page body:

Composer not focused after Ctrl+I

After, the composer has focus:

Composer focused after Ctrl+I

Collapse button after Tab. Before, no ring:

No focus ring

After, an inset accent ring:

Inset focus ring

Workspace actions tooltip. Before:

Tooltip says More actions

After:

Tooltip says Workspace actions

Ctrl+Shift+F with fast mode unavailable. Before, nothing:

No feedback

After, a toast says why:

Fast mode unavailable toast

390 px width:

Phone width

Risks

Low. Each change is local to one control or shortcut. The new Ctrl+I listener exists only while the creation composer is mounted.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T13:29:48.853680Z fd0a766 New commits
🔒 Security Review ✅ Completed 2026-10-06T13:29:37.687194Z fd0a766 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b00cc220f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/features/ChatInput/index.tsx Outdated
Comment thread src/browser/App.tsx
@ThomasK33

Copy link
Copy Markdown
Member Author

Readiness record for head fd0a76681668e780accf907f4bd8cfcc93bbb934:


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

@ThomasK33
ThomasK33 added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 800a993 Oct 6, 2026
32 of 33 checks passed
@ThomasK33
ThomasK33 deleted the fix-focus-labels branch October 6, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant