Skip to content

1/3 Add lightwallet protocol Python bindings#164

Open
pacu wants to merge 1 commit into
mainfrom
grpc-proto-bindings
Open

1/3 Add lightwallet protocol Python bindings#164
pacu wants to merge 1 commit into
mainfrom
grpc-proto-bindings

Conversation

@pacu

@pacu pacu commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Stack order:

  1. This PR: add lightwallet-protocol Python bindings.
  2. grpc-comparison-manual -> grpc-proto-bindings: add the manual gRPC comparison test and framework support.
  3. grpc-comparison-ci -> grpc-comparison-manual: run the gRPC comparison test in CI.

Goal:

Add the protocol definitions and generated Python gRPC stubs needed by later gRPC parity tests, without introducing test framework behavior or CI changes yet.

What is included:

  • walletrpc/*.proto protocol definitions.
  • Generated Python stubs under qa/rpc-tests/test_framework/proto/.
  • grpcio / protobuf dependencies in the uv project files.
  • scripts/generate_proto.sh for regenerating the stubs.
  • Vendored protocol license/changelog files.

Review focus:

This PR should be reviewed mostly as dependency/protocol plumbing. The handwritten test logic comes in PR 2, and CI enablement comes in PR 3.

Local checks run:

  • python -m py_compile qa/rpc-tests/test_framework/proto/*.py
  • bash -n scripts/generate_proto.sh

Co-Authored-By: OpenAI Codex codex@openai.com

Add the lightwallet-protocol proto definitions and generated Python gRPC stubs used by future gRPC parity tests.

Include the grpcio/protobuf dependencies and a helper script for regenerating the stubs.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant